[dm-devel] Question about multipath device compiled defaults

Brian Bunker brian at purestorage.com
Wed Jan 20 16:15:22 UTC 2016


Thank you. Any ideas how long it typically takes the distros like RHEL,
etc. to pull these changes down, or do they need to be pinged explicitly
that there are changes available that we want them to consider?

Brian

On Tue, Jan 19, 2016 at 10:58 PM, Christophe Varoqui <
christophe.varoqui at opensvc.com> wrote:

> Ok, merged.
>
> On Tue, Jan 19, 2016 at 11:17 PM, Brian Bunker <brian at purestorage.com>
> wrote:
>
>> There are just two files I touch, so the patch is simple:
>>
>> diff -Naur 3/multipath-tools/libmultipath/hwtable.c
>> 4/multipath-tools/libmultipath/hwtable.c
>> --- 3/multipath-tools/libmultipath/hwtable.c    2016-01-14
>> 17:47:06.000000000 -0800
>> +++ 4/multipath-tools/libmultipath/hwtable.c    2016-01-14
>> 18:33:45.000000000 -0800
>> @@ -1166,6 +1166,22 @@
>>                 .prio_name     = PRIO_ALUA,
>>                 .prio_args     = NULL,
>>         },
>> +        {
>> +               .vendor        = "PURE",
>> +               .product       = "FlashArray",
>> +               .features      = DEFAULT_FEATURES,
>> +               .hwhandler     = DEFAULT_HWHANDLER,
>> +               .selector      = "queue-length 0",
>> +               .pgpolicy      = MULTIBUS,
>> +               .pgfailback    = -FAILBACK_IMMEDIATE,
>> +               .checker_name  = TUR,
>> +               .fast_io_fail  = 10,
>> +                .user_friendly_names = USER_FRIENDLY_NAMES_OFF,
>> +               .prio_name     = DEFAULT_PRIO,
>> +                .no_path_retry = 0,
>> +                .dev_loss      = 60,
>> +               .prio_args     = NULL,
>> +       },
>>         /*
>>          * EOL
>>          */
>> diff -Naur 3/multipath-tools/multipath.conf.defaults
>> 4/multipath-tools/multipath.conf.defaults
>> --- 3/multipath-tools/multipath.conf.defaults   2016-01-14
>> 17:47:06.000000000 -0800
>> +++ 4/multipath-tools/multipath.conf.defaults   2016-01-14
>> 18:35:50.000000000 -0800
>> @@ -940,6 +940,17 @@
>>  #              rr_weight "uniform"
>>  #              no_path_retry "queue"
>>  #      }
>> +#       device {
>> +#               vendor "PURE"
>> +#               path_selector "queue-length 0"
>> +#               path_grouping_policy "multibus"
>> +#               path_checker "tur"
>> +#               fast_io_fail_tmo 10
>> +#               user_friendly_names "no"
>> +#               no_path_retry 0
>> +#               features 0
>> +#               dev_loss_tmo 60
>> +#       }
>>  #}
>>  #multipaths {
>>  #}
>>
>>
>> Thanks,
>> Brian
>>
>> On Tue, Jan 19, 2016 at 8:48 AM, Christophe Varoqui <
>> christophe.varoqui at opensvc.com> wrote:
>>
>>> Hi,
>>>
>>> and when you are ready, you can post the patch here so I can merge it
>>> upstream.
>>>
>>> Thanks,
>>> Christophe Varoqui
>>> OpenSVC
>>>
>>> On Tue, Jan 19, 2016 at 5:35 PM, Mauricio Faria de Oliveira <
>>> mauricfo at linux.vnet.ibm.com> wrote:
>>>
>>>> On 11/05/2015 04:59 AM, Doron Tal1 wrote:
>>>>
>>>>> I would like to know how and what procedure i should follow if i want
>>>>> to
>>>>> modify or add new settings to the device mapper defaults.
>>>>>
>>>>
>>>> The defaults are in hwtable.c [1].
>>>>
>>>> So for example how can i modify existing compiled settings for the
>>>>> 2810XIV device? in case i want to add a new device and it settings, how
>>>>> can it be done?
>>>>>
>>>>
>>>> To modify the compiled settings, you have to modify it and recompile.
>>>>
>>>> To modify the runtime settings (based on the defaults), you can modify
>>>> /etc/multipath.conf (see its manpage [2] with 'man multipath.conf').
>>>>
>>>> You can verify the the setting values used during multipath discovery
>>>> with 'multipath -v3' for example, or "multipathd -k'show config'".
>>>>
>>>> Hope this might still help at this time,
>>>>
>>>> [1]
>>>> http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=blob;f=libmultipath/hwtable.c
>>>> [2]
>>>> http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=blob;f=multipath/multipath.conf.5
>>>>
>>>> --
>>>> Mauricio Faria de Oliveira
>>>> IBM Linux Technology Center
>>>>
>>>> --
>>>> dm-devel mailing list
>>>> dm-devel at redhat.com
>>>> https://www.redhat.com/mailman/listinfo/dm-devel
>>>>
>>>
>>>
>>> --
>>> dm-devel mailing list
>>> dm-devel at redhat.com
>>> https://www.redhat.com/mailman/listinfo/dm-devel
>>>
>>
>>
>>
>> --
>> Brian Bunker
>> PURE Storage, Inc. <http://www.purestorage.com>
>> brian at purestorage.com
>>
>> --
>> dm-devel mailing list
>> dm-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/dm-devel
>>
>
>
> --
> dm-devel mailing list
> dm-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
>



-- 
Brian Bunker
PURE Storage, Inc. <http://www.purestorage.com>
brian at purestorage.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20160120/06d45793/attachment.htm>


More information about the dm-devel mailing list