[dm-devel] [PATCH v3 0/6] multipath: path validation library prep work

[Martin Wilck]

On Tue, 2020-05-19 at 12:08 -0500, Benjamin Marzinski wrote:
> I've been playing around with the SID code more and I've decided to
> hold
> off on submitting the library until I have it working with the SID
> multipath module better. Instead, I've pulled out the common code
> that
> multipath -u/-c and the library can use, and put it into
> libmultipath.
> 
> I've also removed some of the ordering differences between the
> existing
> code and my new code.  Right now, the only difference is that if a
> path
> is currently multipathed, it will always be claimed as a valid path.
> 
> Patches 0001 & 0002 are the same as in my "RFC PATCH v2" set, and
> patch
> 0005 is the same as my "libmultipath: simplify failed wwid code"
> patch.
> 
> Only patches 0003 and 0004 haven't been posted before.
> 
> Changes from v1:
> 0003: Minor fixes suggested by Martin Wilck
> 0004: Fixed typo, added tests for filter_property() and switched some
>       tests to pass the check_multipathd code in various ways,
> instead
>       of skipping it, as suggested by Martin Wilck
> 
> Changes from v2:
> rebased patches on top of Martin's previous patch sets
> 
> Benjamin Marzinski (5):
>   libmultipath: make libmp_dm_init optional
>   libmultipath: make sysfs_is_multipathed able to return wwid
>   multipath: centralize validation code
>   Unit tests for is_path_valid()
>   libmultipath: simplify failed wwid code
> 
> Martin Wilck (1):
>   libmultipath: use atomic linkat() in mark_failed_wwid()
> 
>  libmultipath/Makefile    |   2 +-
>  libmultipath/devmapper.c |  62 ++++-
>  libmultipath/devmapper.h |   4 +-
>  libmultipath/structs.h   |  24 +-
>  libmultipath/sysfs.c     |  24 +-
>  libmultipath/sysfs.h     |   2 +-
>  libmultipath/valid.c     | 118 ++++++++++
>  libmultipath/valid.h     |  42 ++++
>  libmultipath/wwids.c     | 165 +++++++------
>  multipath/main.c         | 295 ++++++++++--------------
>  tests/Makefile           |   4 +-
>  tests/valid.c            | 486
> +++++++++++++++++++++++++++++++++++++++
>  12 files changed, 943 insertions(+), 285 deletions(-)
>  create mode 100644 libmultipath/valid.c
>  create mode 100644 libmultipath/valid.h
>  create mode 100644 tests/valid.c
> 

You included all the reviewed-by tags from me already, but for the sake
of clarity: ACK for this v3 series.

Thanks,
Martin

-- 
Dr. Martin Wilck <mwilck at suse.com>, Tel. +49 (0)911 74053 2107
SUSE  Software Solutions Germany GmbH
HRB 36809, AG Nürnberg GF: Felix
Imendörffer