[dm-devel] [PATCH 1/3] libmultipath: select_action(): skip is_mpp_known_to_udev() test

mwilck at suse.com mwilck at suse.com
Fri Jan 8 17:00:42 UTC 2021


From: Martin Wilck <mwilck at suse.com>

This test is now superseded by the check introduced in
0d66e03 ("libmultipath: force map reload if udev incomplete").

Signed-off-by: Martin Wilck <mwilck at suse.com>
---
 libmultipath/configure.c | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/libmultipath/configure.c b/libmultipath/configure.c
index d9fd9cb..999f310 100644
--- a/libmultipath/configure.c
+++ b/libmultipath/configure.c
@@ -635,15 +635,6 @@ trigger_paths_udev_change(struct multipath *mpp, bool is_mpath)
 	mpp->needs_paths_uevent = 0;
 }
 
-static int
-is_mpp_known_to_udev(const struct multipath *mpp)
-{
-	struct udev_device *udd = get_udev_for_mpp(mpp);
-	int ret = (udd != NULL);
-	udev_device_unref(udd);
-	return ret;
-}
-
 static int
 sysfs_set_max_sectors_kb(struct multipath *mpp, int is_reload)
 {
@@ -865,12 +856,6 @@ void select_action (struct multipath *mpp, const struct _vector *curmp,
 			mpp->alias);
 		return;
 	}
-	if (!is_mpp_known_to_udev(cmpp)) {
-		mpp->action = ACT_RELOAD;
-		condlog(3, "%s: set ACT_RELOAD (udev device not initialized)",
-			mpp->alias);
-		return;
-	}
 	mpp->action = ACT_NOTHING;
 	condlog(3, "%s: set ACT_NOTHING (map unchanged)",
 		mpp->alias);
-- 
2.29.2





More information about the dm-devel mailing list