[dm-devel] [PATCH 0/3] multipath-tools: cleanup uevent generation on startup

Benjamin Marzinski bmarzins at redhat.com
Tue Jan 12 01:44:36 UTC 2021


On Fri, Jan 08, 2021 at 06:00:41PM +0100, mwilck at suse.com wrote:
> From: Martin Wilck <mwilck at suse.com>

For the set

Reviewed-by: Benjamin Marzinski <bmarzins at redhat.com>

> 
> This series undoes several changes I did myself in an attempt to fix
> issues with multipath maps incompletely initialized in udev. They are
> now all superseded by 0d66e03 ("libmultipath: force map reload if 
> udev incomplete"). Triggering artificial (spurious) uevents for
> dm devices is useless in almost all cases. If some map is found in an
> inconsistent or incomplete state, the only action that would fix it
> is a full map reload.
> 
> While the code reverted here doesn't do actual harm, it unnecessarily
> complicates matters, wastes resources, and may leave readers of
> the code with wrong ideas how to handle udev issues in multipathd.
> 
> Martin Wilck (3):
>   libmultipath: select_action(): skip is_mpp_known_to_udev() test
>   libmultipath: coalesce_paths(): stop triggering spurious uevents
>   Revert "multipathd: uev_trigger(): handle incomplete ADD events"
> 
>  libmultipath/configure.c | 39 ---------------------------------------
>  multipathd/main.c        | 25 -------------------------
>  2 files changed, 64 deletions(-)
> 
> -- 
> 2.29.2




More information about the dm-devel mailing list