[edk2-devel] [Patch v5 2/3] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg.

[Liming Gao]

Sure. Thanks for your detail review. 

> -----Original Message-----
> From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf Of Laszlo Ersek
> Sent: Wednesday, May 8, 2019 2:38 AM
> To: devel at edk2.groups.io; Gao, Liming <liming.gao at intel.com>
> Cc: Wu, Jiaxin <jiaxin.wu at intel.com>; Ye, Ting <ting.ye at intel.com>; Fu, Siyuan <siyuan.fu at intel.com>
> Subject: Re: [edk2-devel] [Patch v5 2/3] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg.
> 
> Hi Liming,
> 
> On 05/07/19 16:27, Liming Gao wrote:
> > This patch provides a set of include segment files for platform owner to
> > easily enable/disable network stack support on their platform.
> >
> > For DSC, there are:
> > - a "NetworkDefines.dsc.inc" for the [Defines] section(s),
> > - a "NetworkLibs.dsc.inc" for the [LibraryClasses*] section(s),
> > - a "NetworkPcds.dsc.inc" for the [Pcds*] section(s),
> > - a "NetworkComponents.dsc.inc" for the [Components*] section(s).
> > For FDF, there is:
> > - a "Network.fdf.inc" for the [Fv*] section(s).
> >
> > These files can be added to the platform DSC/FDF file by using
> >   !include NetworkPkg/xxx
> > where "xxx" is the *.inc file name.
> >
> > A platform DSC file can diverge from the defaults in
> > "NetworkDefines.dsc.inc" by setting the individual DEFINEs before
> > including "NetworkDefines.dsc.inc".
> > And, build command line ("-D FLAG=VALUE") can be used to enable or
> > disable related feature set, please check "NetworkDefines.dsc.inc"
> > for a detail description of each flag.
> >
> > The default value of these flags are:
> >   DEFINE NETWORK_ENABLE                 = TRUE
> >   DEFINE NETWORK_SNP_ENABLE             = TRUE
> >   DEFINE NETWORK_IP4_ENABLE             = TRUE
> >   DEFINE NETWORK_IP6_ENABLE             = TRUE
> >   DEFINE NETWORK_TLS_ENABLE             = TRUE
> >   DEFINE NETWORK_HTTP_BOOT_ENABLE       = TRUE
> >   DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = FALSE
> >   DEFINE NETWORK_ISCSI_ENABLE           = TRUE
> >   DEFINE NETWORK_VLAN_ENABLE            = TRUE
> >
> > Related BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1293
> >
> > Cc: Jiaxin Wu <jiaxin.wu at intel.com>
> > Cc: Ting Ye <ting.ye at intel.com>
> > Signed-off-by: Fu Siyuan <siyuan.fu at intel.com>
> > ---
> >  NetworkPkg/Network.fdf.inc           |  60 ++++++++++++++++++
> >  NetworkPkg/NetworkComponents.dsc.inc |  61 ++++++++++++++++++
> >  NetworkPkg/NetworkDefines.dsc.inc    | 118 +++++++++++++++++++++++++++++++++++
> >  NetworkPkg/NetworkLibs.dsc.inc       |  20 ++++++
> >  NetworkPkg/NetworkPcds.dsc.inc       |  16 +++++
> >  5 files changed, 275 insertions(+)
> >  create mode 100644 NetworkPkg/Network.fdf.inc
> >  create mode 100644 NetworkPkg/NetworkComponents.dsc.inc
> >  create mode 100644 NetworkPkg/NetworkDefines.dsc.inc
> >  create mode 100644 NetworkPkg/NetworkLibs.dsc.inc
> >  create mode 100644 NetworkPkg/NetworkPcds.dsc.inc
> 
> Before you push this patch, please also add your own "Signed-off-by" tag
> at the bottom of the commit message. In the end, the patch should carry
> both Siyuan's and your S-o-b.
> 
> Thanks
> Laszlo
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40149): https://edk2.groups.io/g/devel/message/40149
Mute This Topic: https://groups.io/mt/31532468/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-