[edk2-devel] [Patch v5 2/3] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg.

[Liming Gao]

Laszlo:
  Please allow me clarify it. This is really my mistake, not my intention. I apologize for the missing of your RB. I very appreciate for lots of your review effort and comments. They are helpful to improve the code quality. In fact, this patch set includes three patches. I record your RB and Ack for 1 and 3. But, I miss this one. I admit this my mistake. I think I need to figure out one tool to extract RB or Ack from the mail. It can avoid the manual mistake happen again. 

Thanks
Liming
> -----Original Message-----
> From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf Of Laszlo Ersek
> Sent: Tuesday, May 14, 2019 10:33 PM
> To: devel at edk2.groups.io; Gao, Liming <liming.gao at intel.com>
> Cc: Wu, Jiaxin <jiaxin.wu at intel.com>; Ye, Ting <ting.ye at intel.com>; Fu, Siyuan <siyuan.fu at intel.com>
> Subject: Re: [edk2-devel] [Patch v5 2/3] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg.
> 
> Hi Liming,
> 
> On 05/08/19 02:14, Liming Gao wrote:
> > Sure. Thanks for your detail review.
> 
> I've just noticed that commit 1e948802e755 ("NetworkPkg: Add DSC/FDF
> include segment files to NetworkPkg.", 2019-05-08) does not carry my
> Reviewed-by tag.
> 
> But I worked with you across five iterations of this patch series,
> spending a lot of energy on the review. I gave my R-b here:
> 
>   http://mid.mail-archive.com/5cc12fc5-451a-2924-5179-73c1f192681a@redhat.com
>   https://edk2.groups.io/g/devel/message/40131
> 
> Honestly, this makes me feel like I should just abandon the edk2 project
> for good. I mean if you wanted to intentionally humiliate a reviewer,
> you couldn't do much better than this.
> 
> Laszlo
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40606): https://edk2.groups.io/g/devel/message/40606
Mute This Topic: https://groups.io/mt/31532468/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-