[edk2-devel] [Patch] BaseTools: Remove './SecMain' from 'run' target

[Liming Gao]

Bob:
  Because NT32 has been removed, this change should be OK. Reviewed-by: Liming Gao <liming.gao at intel.com>

Thanks
Liming
> -----Original Message-----
> From: Feng, Bob C
> Sent: Friday, May 10, 2019 3:34 PM
> To: Gao, Liming <liming.gao at intel.com>; devel at edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney at intel.com>
> Subject: RE: [Patch] BaseTools: Remove './SecMain' from 'run' target
> 
> I think NT32Pkg need a POSTBUILD scripts to execute its run command.
> 
> 
> -----Original Message-----
> From: Gao, Liming
> Sent: Friday, May 10, 2019 3:26 PM
> To: Feng, Bob C <bob.c.feng at intel.com>; devel at edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney at intel.com>
> Subject: RE: [Patch] BaseTools: Remove './SecMain' from 'run' target
> 
> Bob:
>   Please make sure run command still works on NT32 platform.
> 
> >-----Original Message-----
> >From: Feng, Bob C
> >Sent: Friday, May 10, 2019 2:34 PM
> >To: devel at edk2.groups.io
> >Cc: Feng, Bob C <bob.c.feng at intel.com>; Gao, Liming
> ><liming.gao at intel.com>; Kinney, Michael D <michael.d.kinney at intel.com>
> >Subject: [Patch] BaseTools: Remove './SecMain' from 'run' target
> >
> >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1561
> >
> >When a target of 'run' is passed into build.py, BaseTools
> >unconditionally attempts to execute the application called './SecMain'
> >in the build output directory.
> >
> >This behavior applies to the Nt32Pkg which is being replaced with
> >features in the EmulatorPkg.
> >
> >Signed-off-by: Bob Feng <bob.c.feng at intel.com>
> >Cc: Liming Gao <liming.gao at intel.com>
> >Cc: Michael D Kinney <michael.d.kinney at intel.com>
> >---
> > BaseTools/Source/Python/build/build.py | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> >diff --git a/BaseTools/Source/Python/build/build.py
> >b/BaseTools/Source/Python/build/build.py
> >index 7271570d29..04f266abf5 100644
> >--- a/BaseTools/Source/Python/build/build.py
> >+++ b/BaseTools/Source/Python/build/build.py
> >@@ -1225,14 +1225,10 @@ class Build():
> >
> >         makefile =
> >GenMake.BuildFile(AutoGenObject)._FILE_NAME_[GenMake.gMakeType]
> >
> >         # run
> >         if Target == 'run':
> >-            RunDir = os.path.normpath(os.path.join(AutoGenObject.BuildDir,
> >GlobalData.gGlobalDefines['ARCH']))
> >-            Command = '.\SecMain'
> >-            os.chdir(RunDir)
> >-            LaunchCommand(Command, RunDir)
> >             return True
> >
> >         # build modules
> >         if BuildModule:
> >             BuildCommand = BuildCommand + [Target]
> >--
> >2.20.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41154): https://edk2.groups.io/g/devel/message/41154
Mute This Topic: https://groups.io/mt/31574316/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-