[edk2-devel] [edk2-test] [PATCH 3/3] uefi-sct/SctPkg: Fix some indentation issues in build.sh

Samer El-Haj-Mahmoud samer.el-haj-mahmoud at arm.com
Wed Nov 11 21:17:21 UTC 2020


Reviewed-By: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com>

> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Rebecca
> Cran via groups.io
> Sent: Thursday, September 24, 2020 5:22 PM
> To: devel at edk2.groups.io
> Cc: Eric Jin <eric.jin at intel.com>; G Edhaya Chandran
> <Edhaya.Chandran at arm.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud at arm.com>; Rebecca Cran <rebecca at nuviainc.com>
> Subject: [edk2-devel] [edk2-test] [PATCH 3/3] uefi-sct/SctPkg: Fix some
> indentation issues in build.sh
>
> build.sh contains a mixture of tabs and spaces, with differing numbers of
> spaces used for indents. Update it so any single block only uses one style of
> indentation.
>
> Signed-off-by: Rebecca Cran <rebecca at nuviainc.com>
> ---
>  uefi-sct/SctPkg/build.sh | 33 ++++++++++++++++-----------------
>  1 file changed, 16 insertions(+), 17 deletions(-)
>
> diff --git a/uefi-sct/SctPkg/build.sh b/uefi-sct/SctPkg/build.sh index
> be610deb..37667711 100755
> --- a/uefi-sct/SctPkg/build.sh
> +++ b/uefi-sct/SctPkg/build.sh
> @@ -56,9 +56,9 @@ function get_gcc_version  {
>  gcc_version=$($1 -dumpversion)
>
> -    if [ ${gcc_version%%.*} -gt 5 ]; then
> -        gcc_version=5
> -    fi
> +if [ ${gcc_version%%.*} -gt 5 ]; then
> +gcc_version=5
> +fi
>
>  case $gcc_version in
>  4.6*|4.7*|4.8*|4.9*|5*)
> @@ -152,10 +152,9 @@ case `uname` in
>  ;;
>
>  GCC* | gcc*)
> -            set_cross_compile
> -        CROSS_COMPILE="$TEMP_CROSS_COMPILE"
> -            export TARGET_TOOLS=`get_gcc_version "$CROSS_COMPILE"gcc`
> -
> +set_cross_compile
> +CROSS_COMPILE="$TEMP_CROSS_COMPILE"
> +export TARGET_TOOLS=`get_gcc_version
> "$CROSS_COMPILE"gcc`
>  ;;
>
>  *)
> @@ -224,7 +223,7 @@ then
>    status=$?
>    if test $status -ne 0
>    then
> -  echo Error while building EDK tools
> +    echo Error while building EDK tools
>      exit -1
>    fi
>  else
> @@ -239,7 +238,7 @@ make -C SctPkg/Tools/Source/GenBin  status=$?
>  if test $status -ne 0
>  then
> -echo Error while building GenBin
> +  echo Error while building GenBin
>    exit -1
>  fi
>
> @@ -258,8 +257,8 @@ build -p SctPkg/UEFI/UEFI_SCT.dsc -a
> $SCT_TARGET_ARCH -t $TARGET_TOOLS -b $SCT_B  status=$?
>  if test $status -ne 0
>  then
> -echo Could not build the UEFI SCT package
> -        exit -1
> +  echo Could not build the UEFI SCT package  exit -1
>  fi
>
>  build -p SctPkg/UEFI/IHV_SCT.dsc -a $SCT_TARGET_ARCH -t
> $TARGET_TOOLS -b $SCT_BUILD $3 $4 $5 $6 $7 $8 $9
> @@ -268,8 +267,8 @@ build -p SctPkg/UEFI/IHV_SCT.dsc -a
> $SCT_TARGET_ARCH -t $TARGET_TOOLS -b $SCT_BU
>  status=$?
>  if test $status -ne 0
>  then
> -echo Could not build the IHV SCT package
> -        exit -1
> +  echo Could not build the IHV SCT package
> +  exit -1
>  fi
>
>
> @@ -299,8 +298,8 @@ pwd
>  status=$?
>  if test $status -ne 0
>  then
> -echo Could not generate UEFI SCT binary
> -     exit -1
> +  echo Could not generate UEFI SCT binary
> +  exit -1
>  else
>  echo The SCT binary "SctPackage${SCT_TARGET_ARCH}" is located at
> "$EFI_SOURCE/Build/UefiSct/${SCT_BUILD}_${TARGET_TOOLS}"
>  fi
> @@ -315,8 +314,8 @@ pwd
>  status=$?
>  if test $status -ne 0
>  then
> -echo Could not generate IHV SCT binary
> -     exit -1
> +  echo Could not generate IHV SCT binary
> +  exit -1
>  else
>  echo The IHV binary "SctPackage${SCT_TARGET_ARCH}" is located at
> "$EFI_SOURCE/Build/IhvSct/${SCT_BUILD}_${TARGET_TOOLS}"
>  fi
> --
> 2.26.2
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#65579): https://edk2.groups.io/g/devel/message/65579
> Mute This Topic: https://groups.io/mt/77067562/1945644
> Group Owner: devel+owner at edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [samer.el-haj-
> mahmoud at arm.com]
> -=-=-=-=-=-=
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67309): https://edk2.groups.io/g/devel/message/67309
Mute This Topic: https://groups.io/mt/77067562/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-






More information about the edk2-devel-archive mailing list