[edk2-devel] [PATCH v5 0/2] CryptoPkg/OpensslLib: Add native instruction support for X64

[Ard Biesheuvel]

On 11/13/20 3:28 AM, Zurcher, Christopher J wrote:
> Laszlo and Ard,
> In the description for commit 214a3b79417f it says "disabling it by default, and re-enabling it explicitly for packages
> that depend on it."
> Is there a documented process to re-enable the COMMON keyword for a particular package? Is this even possible?
> 

Adding -fcommon on the GCC command line should re-enable it, and you 
should be able to do that in package scope. It might mean we'd have to 
move *(COMMON) out of the discards section though.

However, as the commit log explains, COMMON allocation is a *bad* idea 
for highly granular code bases such as EDK2, since it merges variables 
based on their names only.

Do you have any idea why the command line options we use to build 
OpenSSL are not preventing these COMMON sections from being emitted?


>> -----Original Message-----
>> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Zurcher,
>> Christopher J
>> Sent: Thursday, November 12, 2020 17:22
>> To: devel at edk2.groups.io; lersek at redhat.com; Yao, Jiewen
>> <jiewen.yao at intel.com>
>> Cc: gaoliming <gaoliming at byosoft.com.cn>; Wang, Jian J
>> <jian.j.wang at intel.com>; Lu, XiaoyuX <xiaoyux.lu at intel.com>; Kinney, Michael
>> D <michael.d.kinney at intel.com>; Ard Biesheuvel <ard.biesheuvel at arm.com>
>> Subject: Re: [edk2-devel] [PATCH v5 0/2] CryptoPkg/OpensslLib: Add native
>> instruction support for X64
>>
>> Sorry for the thrash on this; in testing the GCC build with .S files, I found
>> that there is still a build failure due to the inclusion of a "common" data
>> section in the OpenSSL code, which is explicitly removed by Base Tools
>> changes in commit 214a3b79417f. So I think without removing this restriction
>> or changing OpenSSL in a future patch, we will not be able to build the
>> accelerated functions for GCC.
>>
>> Thanks,
>> Christopher Zurcher
>>
>>> -----Original Message-----
>>> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Laszlo Ersek
>>> Sent: Wednesday, November 11, 2020 11:09
>>> To: Yao, Jiewen <jiewen.yao at intel.com>; Zurcher, Christopher J
>>> <christopher.j.zurcher at intel.com>
>>> Cc: devel at edk2.groups.io; gaoliming <gaoliming at byosoft.com.cn>; Wang, Jian
>> J
>>> <jian.j.wang at intel.com>; Lu, XiaoyuX <xiaoyux.lu at intel.com>; Kinney,
>> Michael
>>> D <michael.d.kinney at intel.com>; Ard Biesheuvel <ard.biesheuvel at arm.com>
>>> Subject: Re: [edk2-devel] [PATCH v5 0/2] CryptoPkg/OpensslLib: Add native
>>> instruction support for X64
>>>
>>> On 11/11/20 03:19, Yao, Jiewen wrote:
>>>> I full agree with long term plan. E.g. we need remove ApiHook.c as well.
>>>>
>>>> I more concern about the short term plan, if you want to check in this
>> and
>>> get the capability.
>>>>
>>>> I think we need this capability for GCC tool chain as well, so I am OK to
>>> check in .S.
>>>> This is auto generated. I do not think it is a step back.
>>>>
>>>> We can remove them together with ApiHook later, in the long term.
>>>
>>> Agreed on all counts.
>>>
>>> Laszlo
>>>
>>>
>>>
>>>
>>>
>>
>>
>>
>> 
>>
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67518): https://edk2.groups.io/g/devel/message/67518
Mute This Topic: https://groups.io/mt/78017396/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-