[edk2-devel] [PATCH v5 0/2] CryptoPkg/OpensslLib: Add native instruction support for X64

[Laszlo Ersek]

On 11/13/20 08:35, Ard Biesheuvel wrote:
> On 11/13/20 3:28 AM, Zurcher, Christopher J wrote:
>> Laszlo and Ard,
>> In the description for commit 214a3b79417f it says "disabling it by
>> default, and re-enabling it explicitly for packages
>> that depend on it."
>> Is there a documented process to re-enable the COMMON keyword for a
>> particular package? Is this even possible?
>>
> 
> Adding -fcommon on the GCC command line should re-enable it, and you
> should be able to do that in package scope. It might mean we'd have to
> move *(COMMON) out of the discards section though.
> 
> However, as the commit log explains, COMMON allocation is a *bad* idea
> for highly granular code bases such as EDK2, since it merges variables
> based on their names only.
> 
> Do you have any idea why the command line options we use to build
> OpenSSL are not preventing these COMMON sections from being emitted?

My guess is that the GAS source that OpenSSL generates for the crypto
primitives in question is simply broken -- the GAS source probably
includes multiple external definitions (not just declarations) for the
same objects. If that's the case, then it's a genuine bug in OpenSSL.

Thanks
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67533): https://edk2.groups.io/g/devel/message/67533
Mute This Topic: https://groups.io/mt/78017396/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-