[edk2-devel] [PATCH 1/1] uefi-sct/SctPkg: NULL deref in DevicePathToText test

[G Edhaya Chandran]

Hi Heinrich,



   This part is giving a build error, can you please check.



https://github.com/tianocore/edk2-test/commit/75c92b85bf9bb82a7049bf44f40a2741f963230c#diff-7f0df1676a2f898b39de5685efb7a296a7f08e5e5ccb4aaec0a5fdebea926727



[cid:image001.jpg at 01D6C323.F7844200]





/home/zubmoh01/Work/sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/DevicePathToTextBBTestCoverage.c: In function ‘DevicePathToTextConvertDeviceNodeToTextCoverageTest’:
/home/zubmoh01/Work/sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/DevicePathToTextBBTestCoverage.c:1203:49: error: ‘MEDIA_OFFSET_DEVICE_PATH {​​​​​​aka struct <anonymous>}​​​​​​’ has no member named ‘Length’
       ((MEDIA_OFFSET_DEVICE_PATH *)pDeviceNode2)->Length ==
                                                 ^~
"aarch64-linux-gnu-gcc" -MMD -MF /home/zubmoh01/Work/sct/Build/UefiSct/RELEASE_GCC5/AARCH64/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/Dependency/CombinationImage2/CombinationImage2/OUTPUT/ProtocolDefinition.obj.deps   -g -Os -fshort-wchar -fno-builtin -fno-strict-aliasing -Wall -Werror -Wno-array-bounds -include AutoGen.h -fno-common -ffunction-sections -fdata-sections -DSTRING_ARRAY_NAME=ImageServices_CombinationImage2Strings -g -Os -fshort-wchar -fno-builtin -fno-strict-aliasing -Wall -Werror -Wno-array-bounds -include AutoGen.h -fno-common -mlittle-endian -fno-short-enums -fverbose-asm -funsigned-char -ffunction-sections -fdata-sections -Wno-address -fno-asynchronous-unwind-tables -fno-unwind-tables -fno-pic -fno-pie -ffixed-x18 -mcmodel=small -flto -Wno-unused-but-set-variable -Wno-unused-const-variable -D EFIAARCH64 -D EFIAARCH64 -ffreestanding -nostdinc -nostdlib -Wno-error=unused-function -Wno-error=unused-but-set-variable -Wno-error -DMDEPKG_NDEBUG -c -o







With Warm Regards,
Edhay







> -----Original Message-----

> From: Heinrich Schuchardt <xypron.glpk at gmx.de>

> Sent: 24 November 2020 22:38

> To: G Edhaya Chandran <Edhaya.Chandran at arm.com>; devel at edk2.groups.io

> Subject: Re: [edk2-devel] [PATCH 1/1] uefi-sct/SctPkg: NULL deref in

> DevicePathToText test

>

> On 11/24/20 5:33 PM, G Edhaya Chandran wrote:

> > Hi Heinrich,

> >

> >    Oh okay. Actually, I have already upstreamed this.

> > I suggest, I will remove the debug SctPrint myself as part of another upstream.

> >

> > Is it okay?

> >

> > With Warm Regards,

> > Edhay

>

> Thanks for taking care.

>

> Best regards

>

> Heinrich

>

> >

> >

> >> -----Original Message-----

> >> From: Heinrich Schuchardt <xypron.glpk at gmx.de<mailto:xypron.glpk at gmx.de>>

> >> Sent: 24 November 2020 21:57

> >> To: G Edhaya Chandran <Edhaya.Chandran at arm.com<mailto:Edhaya.Chandran at arm.com>>;

> devel at edk2.groups.io<mailto:devel at edk2.groups.io>

> >> Subject: Re: [edk2-devel] [PATCH 1/1] uefi-sct/SctPkg: NULL deref in

> >> DevicePathToText test

> >>

> >> On 11/24/20 5:07 PM, G Edhaya Chandran wrote:

> >>> Upstreamed by commit-id

> >>> :

> >>> https://github.com/tianocore/edk2-test/commit/75c92b85bf9bb82a7049bf

> >>> 44

> >>> f40a2741f963230c

> >>>

> >>

> >> Hello Edhaya,

> >>

> >> it seems a SctPrint() statement slipped into the patch which was only

> >> used for debugging.

> >>

> >> Should I open a new issue? Or just send a patch removing the SctPrint

> >> with reference to #3029?

> >>

> >> Best regards

> >>

> >> Heinrich

> > IMPORTANT NOTICE: The contents of this email and any attachments are

> confidential and may also be privileged. If you are not the intended recipient,

> please notify the sender immediately and do not disclose the contents to any

> other person, use it for any purpose, or store or copy the information in any

> medium. Thank you.

> >



IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67939): https://edk2.groups.io/g/devel/message/67939
Mute This Topic: https://groups.io/mt/77896437/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20201125/012733fc/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.jpg
Type: image/jpeg
Size: 29665 bytes
Desc: image001.jpg
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20201125/012733fc/attachment.jpg>