[edk2-devel] [PATCH edk2-platforms 4/4] Platform/AMD/Styx: remove unused RP0 device

Ard Biesheuvel ard.biesheuvel at arm.com
Fri Jan 8 14:28:50 UTC 2021


The RP0 device has no _HID or _CID or any other identifying attribute,
and its use of _ADR within the scope of the PNP0A08 device object suggests
that _ADR carries a PCIe dev/fn identifier (like the EXPn device objects
earlier in the file), whereas in reality, the address it carries is the
MMIO address of the ECAM window.

So let's just drop it.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel at arm.com>
---
 Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl
index 53ad25ea9a2f..05f3efc40418 100644
--- a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl
+++ b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dsdt.asl
@@ -453,15 +453,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "AMDINC", "SEATTLE ", 3)
               }
               Return (Buffer(){0})
             } // Method(_DSM)
-
-            //
-            // Root-Complex 0
-            //
-            Device (RP0)
-            {
-                Name (_ADR, 0xF0000000)  // _ADR: Bus 0, Dev 0, Func 0
-            }
         }
     }
 }
-
-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70052): https://edk2.groups.io/g/devel/message/70052
Mute This Topic: https://groups.io/mt/79524314/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-





More information about the edk2-devel-archive mailing list