[edk2-devel] [PATCH v5 18/23] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe

[Leif Lindholm]

On Sun, Jan 10, 2021 at 17:21:16 -0700, Rebecca Cran wrote:
> On 1/9/21 7:03 PM, Leif Lindholm wrote:
> > On Mon, Jan 04, 2021 at 15:58:25 -0700, Rebecca Cran wrote:
> 
> > > +#include <Protocol/Smbios.h>
> > > +#include <IndustryStandard/SmBios.h>
> > 
> > We appear to still have a discrepancy w.r.t. Smbios/SmBios capitalisation.
> 
> I was planning to commit the SMBIOS series and then fix the capitalization
> of the header to be Smbios.h - should I do it the other way around?

That would make this set cleaner.

Also, we're approaching the halfway point of this development cycle,
and since renaming IndustryStandard/SmBios.h and Guid/SmBios.h *will*
break many out-of-tree platforms, it's better to get it in sooner
rather than later.

(Presumably builds on Windows and Os X will succeed anyway, but ...)

It would be nice if you could also submit a set fixing up the include
statements in all of the edk2-platforms ports.

/
    Leif


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70095): https://edk2.groups.io/g/devel/message/70095
Mute This Topic: https://groups.io/mt/79438423/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-