回复: [edk2-devel] [PATCH v5 18/23] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe

[gaoliming]

Leif:
  There are three SmBios.h files in MdePkg. Their file name are
inconsistent. But, they exist since they were added, Protocol\Smbios.h was
added on 2009. This is the known issue. So, I don't suggest to rename their
file name.

MdePkg\Include\Guid\SmBios.h
MdePkg\Include\Protocol\Smbios.h
MdePkg\Include\IndustryStandard\SmBios.h

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+70095+4905953+8761045 at groups.io
> <bounce+27952+70095+4905953+8761045 at groups.io> 代表 Leif Lindholm
> 发送时间: 2021年1月11日 9:30
> 收件人: Rebecca Cran <rebecca at nuviainc.com>
> 抄送: devel at edk2.groups.io; Ard Biesheuvel <ard.biesheuvel at arm.com>; nd
> @ arm . com . Sami Mujawar <Sami.Mujawar at arm.com>; Liming Gao
> <gaoliming at byosoft.com.cn>; Michael D Kinney
> <michael.d.kinney at intel.com>; Zhiguang Liu <zhiguang.liu at intel.com>
> 主题: Re: [edk2-devel] [PATCH v5 18/23] ArmPkg: Add
> Universal/Smbios/SmbiosMiscDxe
> 
> On Sun, Jan 10, 2021 at 17:21:16 -0700, Rebecca Cran wrote:
> > On 1/9/21 7:03 PM, Leif Lindholm wrote:
> > > On Mon, Jan 04, 2021 at 15:58:25 -0700, Rebecca Cran wrote:
> >
> > > > +#include <Protocol/Smbios.h>
> > > > +#include <IndustryStandard/SmBios.h>
> > >
> > > We appear to still have a discrepancy w.r.t. Smbios/SmBios
capitalisation.
> >
> > I was planning to commit the SMBIOS series and then fix the
capitalization
> > of the header to be Smbios.h - should I do it the other way around?
> 
> That would make this set cleaner.
> 
> Also, we're approaching the halfway point of this development cycle,
> and since renaming IndustryStandard/SmBios.h and Guid/SmBios.h *will*
> break many out-of-tree platforms, it's better to get it in sooner
> rather than later.
> 
> (Presumably builds on Windows and Os X will succeed anyway, but ...)
> 
> It would be nice if you could also submit a set fixing up the include
> statements in all of the edk2-platforms ports.
> 
> /
>     Leif
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70106): https://edk2.groups.io/g/devel/message/70106
Mute This Topic: https://groups.io/mt/79590104/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-