[edk2-devel] [edk2-platforms PATCH 0/1] Update SMBIOS includes to use capitalization 'Smbios.h' vs 'SmBios.h'

Michael D Kinney michael.d.kinney at intel.com
Mon Jan 11 04:42:49 UTC 2021


Hi Rebecca,

Where is the review of the change to rename SmBios.h to Smbios.h in MdePkg?

I do not think that change is a good idea because it would impact every downstream platform
that produces SMBIOS records.

Mike

> -----Original Message-----
> From: Rebecca Cran <rebecca at nuviainc.com>
> Sent: Sunday, January 10, 2021 7:31 PM
> To: devel at edk2.groups.io
> Cc: Rebecca Cran <rebecca at nuviainc.com>; Chaganty, Rangasai V <rangasai.v.chaganty at intel.com>; Liming Gao
> <gaoliming at byosoft.com.cn>; Kinney, Michael D <michael.d.kinney at intel.com>; Steele, Kelly <kelly.steele at intel.com>;
> Agyeman, Prince <prince.agyeman at intel.com>; Sun, Zailiang <zailiang.sun at intel.com>; Qian, Yi <yi.qian at intel.com>; Leif
> Lindholm <leif at nuviainc.com>; Ard Biesheuvel <ardb+tianocore at kernel.org>; Wenyi Xie <xiewenyi2 at huawei.com>; Chiu, Chasel
> <chasel.chiu at intel.com>; Ni, Ray <ray.ni at intel.com>; Abner Chang <abner.chang at hpe.com>; Daniel Schaefer
> <daniel.schaefer at hpe.com>; Gilbert Chen <gilbert.chen at hpe.com>; Thomas Abraham <thomas.abraham at arm.com>; Pete Batard
> <pete at akeo.ie>; Marcin Wojtas <mw at semihalf.com>
> Subject: [edk2-platforms PATCH 0/1] Update SMBIOS includes to use capitalization 'Smbios.h' vs 'SmBios.h'
> 
> Update SMBIOS includes to use capitalization 'Smbios.h' vs 'SmBios.h'
> 
> This patch depends on the corresponding edk2 change with subject
> "Various packages: rename SmBios.h to Smbios.h in MdePkg and update references through edk2 tree".
> 
> Rebecca Cran (1):
>   Update SMBIOS includes to use capitalization 'Smbios.h' vs 'SmBios.h'
> 
>  Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec               | 10 +++++-----
>  Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosBasicDxe/SmbiosBasic.h       |  2 +-
>  Platform/Intel/QuarkPlatformPkg/Platform/Dxe/MemorySubClass/MemorySubClass.h         |  2 +-
>  Platform/Intel/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/CommonHeader.h            |  2 +-
>  Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHook.h             |  4 ++--
>  Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsPlatform.h       |  4 ++--
>  Platform/Intel/SimicsOpenBoardPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.h              |  2 +-
>  Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/CommonHeader.h                        |  2 +-
>  Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.h                     |  2 +-
>  Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClass.h                  |  2 +-
>  Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.h            |  2 +-
>  Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMisc.h                          |  2 +-
>  Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolicyLibrary.h |  2 +-
>  Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h         |  2 +-
>  Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolicyLibrary.h   |  2 +-
>  Silicon/RISC-V/ProcessorPkg/Include/ProcessorSpecificHobData.h                       |  2 +-
>  Silicon/RISC-V/ProcessorPkg/Include/SmbiosProcessorSpecificData.h                    |  2 +-
>  Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c                           |  2 +-
>  Platform/Hisilicon/D03/Library/OemMiscLib2P/BoardFeature2PHi1610.c                   |  2 +-
>  Platform/Hisilicon/D05/Library/OemMiscLibD05/BoardFeatureD05.c                       |  2 +-
>  Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c                       |  2 +-
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/SetupInfoRecords.c                 |  2 +-
>  Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c                   |  4 ++--
>  Platform/Socionext/DeveloperBox/SmbiosPlatformDxe/SmbiosPlatformDxe.c                |  2 +-
>  Silicon/AMD/Styx/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c                       |  4 ++--
>  Silicon/Intel/IntelSiliconPkg/Library/DxeSmbiosDataHobLib/DxeSmbiosDataHobLib.c      |  2 +-
>  Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c                        |  2 +-
>  27 files changed, 35 insertions(+), 35 deletions(-)
> 
> --
> 2.26.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70102): https://edk2.groups.io/g/devel/message/70102
Mute This Topic: https://groups.io/mt/79588714/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-






More information about the edk2-devel-archive mailing list