回复: [edk2-devel] [edk2-platforms PATCH 0/1] Update SMBIOS includes to use capitalization 'Smbios.h' vs 'SmBios.h'

[gaoliming]

Mike:
  I see the discussion about renaming file name in https://edk2.groups.io/g/devel/message/70095. 

  I also think this change impact is big. I suggest to discuss it more before we make the change. 

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+70102+4905953+8761045 at groups.io
> <bounce+27952+70102+4905953+8761045 at groups.io> 代表 Michael D
> Kinney
> 发送时间: 2021年1月11日 12:43
> 收件人: Rebecca Cran <rebecca at nuviainc.com>; devel at edk2.groups.io;
> Kinney, Michael D <michael.d.kinney at intel.com>
> 抄送: Chaganty, Rangasai V <rangasai.v.chaganty at intel.com>; Liming Gao
> <gaoliming at byosoft.com.cn>; Steele, Kelly <kelly.steele at intel.com>;
> Agyeman, Prince <prince.agyeman at intel.com>; Sun, Zailiang
> <zailiang.sun at intel.com>; Qian, Yi <yi.qian at intel.com>; Leif Lindholm
> <leif at nuviainc.com>; Ard Biesheuvel <ardb+tianocore at kernel.org>; Wenyi
> Xie <xiewenyi2 at huawei.com>; Chiu, Chasel <chasel.chiu at intel.com>; Ni,
> Ray <ray.ni at intel.com>; Abner Chang <abner.chang at hpe.com>; Daniel
> Schaefer <daniel.schaefer at hpe.com>; Gilbert Chen <gilbert.chen at hpe.com>;
> Thomas Abraham <thomas.abraham at arm.com>; Pete Batard
> <pete at akeo.ie>; Marcin Wojtas <mw at semihalf.com>
> 主题: Re: [edk2-devel] [edk2-platforms PATCH 0/1] Update SMBIOS includes
> to use capitalization 'Smbios.h' vs 'SmBios.h'
> 
> Hi Rebecca,
> 
> Where is the review of the change to rename SmBios.h to Smbios.h in
> MdePkg?
> 
> I do not think that change is a good idea because it would impact every
> downstream platform
> that produces SMBIOS records.
> 
> Mike
> 
> > -----Original Message-----
> > From: Rebecca Cran <rebecca at nuviainc.com>
> > Sent: Sunday, January 10, 2021 7:31 PM
> > To: devel at edk2.groups.io
> > Cc: Rebecca Cran <rebecca at nuviainc.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty at intel.com>; Liming Gao
> > <gaoliming at byosoft.com.cn>; Kinney, Michael D
> <michael.d.kinney at intel.com>; Steele, Kelly <kelly.steele at intel.com>;
> > Agyeman, Prince <prince.agyeman at intel.com>; Sun, Zailiang
> <zailiang.sun at intel.com>; Qian, Yi <yi.qian at intel.com>; Leif
> > Lindholm <leif at nuviainc.com>; Ard Biesheuvel
> <ardb+tianocore at kernel.org>; Wenyi Xie <xiewenyi2 at huawei.com>; Chiu,
> Chasel
> > <chasel.chiu at intel.com>; Ni, Ray <ray.ni at intel.com>; Abner Chang
> <abner.chang at hpe.com>; Daniel Schaefer
> > <daniel.schaefer at hpe.com>; Gilbert Chen <gilbert.chen at hpe.com>;
> Thomas Abraham <thomas.abraham at arm.com>; Pete Batard
> > <pete at akeo.ie>; Marcin Wojtas <mw at semihalf.com>
> > Subject: [edk2-platforms PATCH 0/1] Update SMBIOS includes to use
> capitalization 'Smbios.h' vs 'SmBios.h'
> >
> > Update SMBIOS includes to use capitalization 'Smbios.h' vs 'SmBios.h'
> >
> > This patch depends on the corresponding edk2 change with subject
> > "Various packages: rename SmBios.h to Smbios.h in MdePkg and update
> references through edk2 tree".
> >
> > Rebecca Cran (1):
> >   Update SMBIOS includes to use capitalization 'Smbios.h' vs 'SmBios.h'
> >
> >
> Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec
> | 10 +++++-----
> >
> Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosBasicDxe/Smbio
> sBasic.h       |  2 +-
> >
> Platform/Intel/QuarkPlatformPkg/Platform/Dxe/MemorySubClass/MemorySu
> bClass.h         |  2 +-
> >
> Platform/Intel/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/CommonHea
> der.h            |  2 +-
> >
> Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHoo
> k.h             |  4 ++--
> >
> Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsPla
> tform.h       |  4 ++--
> >
> Platform/Intel/SimicsOpenBoardPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.
> h              |  2 +-
> >  Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/CommonHeader.h
> |  2 +-
> >  Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.h
> |  2 +-
> >  Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClass.h
> |  2 +-
> >
> Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.h
> |  2 +-
> >  Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMisc.h
> |  2 +-
> >
> Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolicyL
> ibrary.h |  2 +-
> >
> Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h
> |  2 +-
> >
> Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolicyLib
> rary.h   |  2 +-
> >  Silicon/RISC-V/ProcessorPkg/Include/ProcessorSpecificHobData.h
> |  2 +-
> >  Silicon/RISC-V/ProcessorPkg/Include/SmbiosProcessorSpecificData.h
> |  2 +-
> >  Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> |  2 +-
> >  Platform/Hisilicon/D03/Library/OemMiscLib2P/BoardFeature2PHi1610.c
> |  2 +-
> >  Platform/Hisilicon/D05/Library/OemMiscLibD05/BoardFeatureD05.c
> |  2 +-
> >  Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c
> |  2 +-
> >  Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/SetupInfoRecords.c
> |  2 +-
> >  Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c
> |  4 ++--
> >
> Platform/Socionext/DeveloperBox/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> |  2 +-
> >  Silicon/AMD/Styx/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c
> |  4 ++--
> >
> Silicon/Intel/IntelSiliconPkg/Library/DxeSmbiosDataHobLib/DxeSmbiosDataHo
> bLib.c      |  2 +-
> >  Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> |  2 +-
> >  27 files changed, 35 insertions(+), 35 deletions(-)
> >
> > --
> > 2.26.2
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70103): https://edk2.groups.io/g/devel/message/70103
Mute This Topic: https://groups.io/mt/79589994/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-