[edk2-devel] [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add further named components
Samer El-Haj-Mahmoud
samer.el-haj-mahmoud at arm.com
Mon May 10 16:42:06 UTC 2021
+ Ard's new e-mail address
From: Andrei Warkentin <awarkentin at vmware.com>
Sent: Thursday, April 8, 2021 10:17 AM
To: Jeremy Linton <Jeremy.Linton at arm.com>; devel at edk2.groups.io
Cc: Ard Biesheuvel <Ard.Biesheuvel at arm.com>; leif at nuviainc.com; pete at akeo.ie; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com>
Subject: Re: [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add further named components
Reviewed-by: Andrei Warkentin <awarkentin at vmware.com<mailto:awarkentin at vmware.com>>
________________________________
From: Jeremy Linton <jeremy.linton at arm.com<mailto:jeremy.linton at arm.com>>
Sent: Thursday, April 8, 2021 12:58 AM
To: devel at edk2.groups.io<mailto:devel at edk2.groups.io> <devel at edk2.groups.io<mailto:devel at edk2.groups.io>>
Cc: ard.biesheuvel at arm.com<mailto:ard.biesheuvel at arm.com> <ard.biesheuvel at arm.com<mailto:ard.biesheuvel at arm.com>>; leif at nuviainc.com<mailto:leif at nuviainc.com> <leif at nuviainc.com<mailto:leif at nuviainc.com>>; pete at akeo.ie<mailto:pete at akeo.ie> <pete at akeo.ie<mailto:pete at akeo.ie>>; samer.el-haj-mahmoud at arm.com<mailto:samer.el-haj-mahmoud at arm.com> <samer.el-haj-mahmoud at arm.com<mailto:samer.el-haj-mahmoud at arm.com>>; Andrei Warkentin <awarkentin at vmware.com<mailto:awarkentin at vmware.com>>; Jeremy Linton <jeremy.linton at arm.com<mailto:jeremy.linton at arm.com>>
Subject: [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add further named components
Add some additional IORT nodes for the USB & EMMC devices, realistically
we probably only need to have a single node with the lowest AddressSizeLimit
but this is conceptually "cleaner" should anyone actually try and use these
values rather than the _DMA provided ones.
Signed-off-by: Jeremy Linton <jeremy.linton at arm.com<mailto:jeremy.linton at arm.com>>
---
Platform/RaspberryPi/AcpiTables/Iort.aslc | 44 ++++++++++++++++++++++++++++++-
1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/AcpiTables/Iort.aslc b/Platform/RaspberryPi/AcpiTables/Iort.aslc
index 00720194bb..810307ae37 100644
--- a/Platform/RaspberryPi/AcpiTables/Iort.aslc
+++ b/Platform/RaspberryPi/AcpiTables/Iort.aslc
@@ -20,6 +20,8 @@ typedef struct {
typedef struct {
EFI_ACPI_6_0_IO_REMAPPING_TABLE Iort;
RPI4_NC_NODE NamedCompNode;
+ RPI4_NC_NODE NamedCompNode2;
+ RPI4_NC_NODE NamedCompNode3;
} RPI4_IO_REMAPPING_STRUCTURE;
STATIC RPI4_IO_REMAPPING_STRUCTURE Iort = {
@@ -27,7 +29,7 @@ STATIC RPI4_IO_REMAPPING_STRUCTURE Iort = {
ACPI_HEADER (EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE,
RPI4_IO_REMAPPING_STRUCTURE,
EFI_ACPI_IO_REMAPPING_TABLE_REVISION),
- 1, // NumNodes
+ 3, // NumNodes
sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE), // NodeOffset
0 // Reserved
}, {
@@ -50,6 +52,46 @@ STATIC RPI4_IO_REMAPPING_STRUCTURE Iort = {
}, {
"\\_SB_.SCB0.XHC0<file://_SB_.SCB0.XHC0>" // ObjectName
}
+ }, {
+ // gpu/dwc usb named component node
+ {
+ {
+ EFI_ACPI_IORT_TYPE_NAMED_COMP, // Type
+ sizeof (RPI4_NC_NODE), // Length
+ 0x0, // Revision
+ 0x0, // Reserved
+ 0x0, // NumIdMappings
+ 0x0, // IdReference
+ },
+ 0x0, // Flags
+ 0x0, // CacheCoherent
+ 0x0, // AllocationHints
+ 0x0, // Reserved
+ 0x0, // MemoryAccessFlags
+ 30, // AddressSizeLimit
+ }, {
+ "\\_SB_.GDV0.USB0<file://_SB_.GDV0.USB0>" // ObjectName
+ }
+ }, {
+ // emmc2 named component node
+ {
+ {
+ EFI_ACPI_IORT_TYPE_NAMED_COMP, // Type
+ sizeof (RPI4_NC_NODE), // Length
+ 0x0, // Revision
+ 0x0, // Reserved
+ 0x0, // NumIdMappings
+ 0x0, // IdReference
+ },
+ 0x0, // Flags
+ 0x0, // CacheCoherent
+ 0x0, // AllocationHints
+ 0x0, // Reserved
+ 0x0, // MemoryAccessFlags
+ 30, // AddressSizeLimit
+ }, {
+ "\\_SB_.GDV1.SDC3<file://_SB_.GDV1.SDC3>" // ObjectName
+ }
}
};
--
2.13.7
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#74893): https://edk2.groups.io/g/devel/message/74893
Mute This Topic: https://groups.io/mt/81935644/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20210510/1949d544/attachment.htm>
More information about the edk2-devel-archive
mailing list