[et-mgmt-tools] koan 0.2.9 parsing problem (safe_load function)

[Adam Rosenwald]

Thanks for the quick release, Michael.

On 4/24/07, Michael DeHaan <mdehaan at redhat.com> wrote:
>
> Adam Rosenwald wrote:
> > Works like a charm w/ centos-5!!! Thanks, Michael!  :)
> >
> > On 4/23/07, *Michael DeHaan* <mdehaan at redhat.com
> > <mailto:mdehaan at redhat.com>> wrote:
> >
> >     Adam Rosenwald wrote:
> >     > New issue with cobbler 0.4.7 and koan 0.2.9.
> >     >
> >     > After installing cobbler 0.4.7 (from RPM), I made `cobbler check`
> >     > happy, and then proceeded with provisioning `cobbler system add
> >     > --name=00:16:3E:35:00:71 <--additional items>`.  No problem.  The
> >     > system profile was allocated properly.
> >     >
> >     > Then, I ensure cobblerd was running.  No problem with XMLRPC port.
> >     >
> >     > I had a dom0 server on which I installed koan 0.2.9 (from RPM).
> >     >
> >     > Then...
> >     >
> >     > ====BEGIN OUTPUT=====
> >     >
> >     > ... SNIP ....
> >     >
> >     > =======END OUTPUT==========
> >     >
> >     > It appears that 'profile' is beting passed as a hash to
> safe_load(),
> >     > yet there is something wrong with the hash.
> >     >
> >     > This problem does not occur when running koan with
> >     > --profile=<profile_name>; rather it only occurs with
> >     > --system=<system_name>.
> >     >
> >     > Any thoughts?  Thanks. --A.
> >     >
> >
> ------------------------------------------------------------------------
> >     >
> >     > _______________________________________________
> >     > et-mgmt-tools mailing list
> >     > et-mgmt-tools at redhat.com <mailto:et-mgmt-tools at redhat.com>
> >     > https://www.redhat.com/mailman/listinfo/et-mgmt-tools
> >
> >     Fix:
> >
> >     diff --git a/koan/app.py b/koan/app.py
> >     index 1a9205a..08d4ee6 100755
> >     --- a/koan/app.py
> >     +++ b/koan/app.py
> >     @@ -524,7 +524,7 @@ class Koan:
> >              system_data = None
> >              self.debug("fetching configuration for system: %s" %
> >     old_system_name)
> >              try:
> >     -            data =
> >     self.xmlrpc_server.get_system_for_koan(system_name)
> >     +            system_data =
> >     self.xmlrpc_server.get_system_for_koan(system_name)
> >              except:
> >                  self.connect_fail()
> >              profile_data =
> >     self.get_profile_xmlrpc(self.safe_load(system_data,'profile'))
> >
> >
> >     I'll push a koan update shortly to include this (probably
> >     tomorrow) ...
> >     I want to see if any other sparks fly first.
> >
> >     --Michael
> >
> >
> Done -- this is koan 0.3.0 which should be available for D/L now and has
> also been pushed to Fedora.  I've also fixed a small bug where it would
> incorrectly interpret a MAC address as an IP in some cases.
>
> >
> >     _______________________________________________
> >     et-mgmt-tools mailing list
> >     et-mgmt-tools at redhat.com <mailto:et-mgmt-tools at redhat.com>
> >     https://www.redhat.com/mailman/listinfo/et-mgmt-tools
> >
> >
> > ------------------------------------------------------------------------
> >
> > _______________________________________________
> > et-mgmt-tools mailing list
> > et-mgmt-tools at redhat.com
> > https://www.redhat.com/mailman/listinfo/et-mgmt-tools
>
> _______________________________________________
> et-mgmt-tools mailing list
> et-mgmt-tools at redhat.com
> https://www.redhat.com/mailman/listinfo/et-mgmt-tools
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/et-mgmt-tools/attachments/20070425/e56e21d2/attachment.htm>