[et-mgmt-tools] [PATCH] virt-manager: Add additional info to disk details section

[Cole Robinson]

Daniel P. Berrange wrote:
> On Mon, Dec 10, 2007 at 01:49:18PM -0500, Cole Robinson wrote:
>> The attached patch adds a couple fields to the details section for a disk
>> device in virt-manager: a 'Driver' field and a 'Permissions' field. The
>> driver field is written as "file" or "tap:aio" etc., and the permissions
>> field appears as "Readonly" or "Read/Write", with ", Sharable" tacked on
>> the end if applicable.
> 
> I've no problem adding the readonly/readwrite/sharable  information.
> 
> I don't want the file:/tap:aio/etc stuff shown. Its an underlying implementation
> detail over which the admin has no control - we automatically pick the driver
> required according to virt type - and as such its not useful to show and people
> aren't going to understand what it means.
> 
> Regards,
> Dan.

Reworked patch attached removing driver field.

- Cole

-- 
Cole Robinson
crobinso at redhat.com
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: disk-driver-perms-details-patch-2
URL: <http://listman.redhat.com/archives/et-mgmt-tools/attachments/20071214/0415a5b1/attachment.ksh>