[et-mgmt-tools] [PATCH] virt-manager: Add additional info to disk details section

[Daniel P. Berrange]

On Fri, Dec 14, 2007 at 10:58:06AM -0500, Cole Robinson wrote:
> Daniel P. Berrange wrote:
> > On Mon, Dec 10, 2007 at 01:49:18PM -0500, Cole Robinson wrote:
> >> The attached patch adds a couple fields to the details section for a disk
> >> device in virt-manager: a 'Driver' field and a 'Permissions' field. The
> >> driver field is written as "file" or "tap:aio" etc., and the permissions
> >> field appears as "Readonly" or "Read/Write", with ", Sharable" tacked on
> >> the end if applicable.
> > 
> > I've no problem adding the readonly/readwrite/sharable  information.
> > 
> > I don't want the file:/tap:aio/etc stuff shown. Its an underlying implementation
> > detail over which the admin has no control - we automatically pick the driver
> > required according to virt type - and as such its not useful to show and people
> > aren't going to understand what it means.
> > 
> > Regards,
> > Dan.
> 
> Reworked patch attached removing driver field.

Thanks, looks good.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|