[et-mgmt-tools] [PATCH] virtinst: Add 'clock' parameter for hvm guest installs

Cole Robinson crobinso at redhat.com
Tue Dec 18 14:57:14 UTC 2007


Daniel P. Berrange wrote:
> On Mon, Dec 17, 2007 at 12:40:33PM -0500, Cole Robinson wrote:
>> The attached patch adds a 'clock' key to the full virt guest parameters
>> dictionary in virtinst. The main reasoning for this is to specify 'localtime'
>> instead of 'utc' for a windows guest. If no guest type is specified, the
>> generated xml doesn't contain a clock field and uses libvirt's default, which
>> is the current action.
> 
> Looks good. You'll need to also update the tests/*.xml files too though to
> add in info about the new <clock> element, otherwise 'python setup.py test'
> will fail
> 
> Regards,
> Dan.

I committed this yesterday with the appropriate test changes.

http://hg.et.redhat.com/virt/applications/virtinst--devel?cs=325a56861208

- Cole




More information about the et-mgmt-tools mailing list