[et-mgmt-tools] [PATCH] virt-install 0.101.0 can't install

Saori Fukuta fukuta.saori at jp.fujitsu.com
Wed Feb 28 08:47:29 UTC 2007


Hi,

I can't install with current virt-install ( version: 0.101.0 ).

I think the cause is the difference in following:
    getting OS type from libvirt : Xen (capital letter)
    check string at virt-install : xen (small letter)
So, I fix the string "xen" to "Xen" and I can install.

But, I worry about that libvirt has some return code.
    e.g.)
    xen_internal.c  ... return("Xen");
    xend_internal.c ... return("XenDaemon");
    xm_internal.c   ... return ("XenXM");
Is that all right?

Signed-off-by: Saori Fukuta <fukuta.saori at jp.fujitsu.com>

Thanks,
Saori Fukuta.

Index: virt-install ( version: 0.101.0 )
===================================================================
--- virt-install        2007-02-28 22:49:27.000000000 +0900
+++ virt-install.new    2007-03-01 02:25:30.000000000 +0900
@@ -371,7 +371,7 @@ def main():
     conn = libvirt.open(options.connect)
     type = None
     # check to ensure we're really on a xen kernel
-    if conn.getType() == "xen":
+    if conn.getType() == "Xen":
         type = "xen"
         check_xen()

@@ -381,7 +381,7 @@ def main():

     # first things first, are we trying to create a fully virt guest?
     hvm = False
-    if conn.getType() == "xen":
+    if conn.getType() == "Xen":
         if virtinst.util.is_hvm_capable():
             hvm = options.fullvirt
         if hvm is None:





More information about the et-mgmt-tools mailing list