[et-mgmt-tools] [PATCH][RESEND}Check the starting domain's uuid
hbrock at redhat.com
Tue Mar 13 14:14:05 UTC 2007
Tatsuro Enokura wrote:
> Would you give me a comment on this patch?
> If not, please apply it.
> Tatsuro Enokura wrote:
>> The virt-install command has a problem that the information of
>> the existent domain is overwritten by virt-install command
>> specifing the domain's uuid.
>> Futhermore, the existent domain's set-up file is overwritten
>> on the xen-3.0.4.
>> I make a patch checking the starting domain's uuid on Guest.py.
> Signed-off-by: Tatsuro Enokura <fj1826dm at aa.jp.fujitsu.com>
> Tatsuro Enokura
This should be fine. The only problem I have with it is that the libvirt
Python API is a bit broken on this point -- it should really return None
without an error condition if the domain does not exist, rather than
raising an error. In anticipation that the libvirt Python API will
eventually be fixed to work properly in this case, I've added "else"
clauses that handle the case where the lookup returns None but does not
throw an error. With that minor change, applied.
Red Hat Virtualization Group http://redhat.com/virtualization
Hugh Brock | virt-manager http://virt-manager.org
hbrock at redhat.com | virtualization library http://libvirt.org
More information about the et-mgmt-tools