[et-mgmt-tools] [PATCH] [RESEND]Check the making domain's mac address(part 2)

Hugh Brock hbrock at redhat.com
Mon Mar 26 16:11:15 UTC 2007

Tatsuro Enokura wrote:
> Hi
> Would you give me a comment on this patch?
> If not, please apply it.
> Tatsuro Enokura wrote:
>> I made the patch the running domain's mac address check(changeset 125),
>> I make the patch in this time that the virt-install comand adds the
>> confirming message.
>> The attached patch the following way:
>>   1) Count that the making domian's MAC address is already use
>>      the exists domain's MAC address.
>>   2) Check the hots's  NIC MAC address.
>>   2) if count > 0 or , print confirmation message.
>>   3) if type yes then leave disk source as it is,
>>      else ask disk source again.
> Signed-off-by: Tatsuro Enokura <fj7716hz at aa.jp.fujitsu.com>
> Thanks,
> Tatsuro Enokura

Hi. I had a look at the patch. The idea is OK, but there are two
problems: first, I'd rather you not use exceptions for flow control;
when you're testing for the mac address, if there's a problem, go
straight to the user check rather than going through the whole try:
except: sequence. Second problem is when I try it with a pre-existing
mac address from the command line for an inactive, I no longer get a
warning of a duplicate (which you set up in your last patch).

If you can check these things and resubmit, I'd be happy to take it.


Red Hat Virtualization Group http://redhat.com/virtualization
Hugh Brock           | virt-manager http://virt-manager.org
hbrock at redhat.com    | virtualization library http://libvirt.org

More information about the et-mgmt-tools mailing list