[et-mgmt-tools] [PATCH] [RESEND]Check the making domain's mac address(part 2)
fj7716hz at aa.jp.fujitsu.com
Tue Mar 27 04:26:10 UTC 2007
Hugh Brock wrote:
> Hi. I had a look at the patch. The idea is OK, but there are two
> problems: first, I'd rather you not use exceptions for flow control;
> when you're testing for the mac address, if there's a problem, go
> straight to the user check rather than going through the whole try:
> except: sequence.
Thank you for youre reviewing.
I rewrite a patch.
> Second problem is when I try it with a pre-existing
> mac address from the command line for an inactive, I no longer get a
> warning of a duplicate (which you set up in your last patch).
I assume User run various domains with specified time.
For this case, I just show warning messages only.
Since user intent to run the same mac address
with various domain in various time.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
More information about the et-mgmt-tools