[et-mgmt-tools] libvirt and query strings in EL 5.1 behaves differently than F9

[Daniel P. Berrange]

On Tue, Apr 22, 2008 at 06:46:21PM -0400, Michael DeHaan wrote:
> I was talking to Dan yesterday on OFTC about how to express query 
> strings in libvirt.   Basically the new Cobbler wants to generate 
> kickstarts on the fly, and also do some fun things about remote 
> registration.   This already works for PXE but I am having trouble 
> passing the kernel options line into libvirt still.   What I was trying was:
> 
>    For instance:
>       ks=http://server.example.com/blah?op=ks&profile=blah   [OR]
>       ks=http://server.example.com/blah?op=ks;profile=blah
> 
> Under F9, this works for me correctly when I use the former method and do
> 
>    extra = extra.replace("&","&")
> 
> However I have recieved reports today that the above does not work on 
> EL-5.1, where it (also replicated with virsh) chokes -- giving a message 
> that the end of the XML was unexpected (see pastebin below).   I am 
> thinking the XML escaping built into virt-install/libvirt may not be the 
> same in EL-5.1? 

It isn't libvirt's job to escape the query string - it just receives
the XML document which must already be valid. If you're using virt-install
APIs for building the XML document, then it is virt-install's job to do
attribute escaping. This was broken in RHEL-5.1 and is fixed for 5.2
and Fedora 8 onwards

https://bugzilla.redhat.com/show_bug.cgi?id=417051

Dan.
-- 
|: Red Hat, Engineering, Boston   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|