[et-mgmt-tools] [PATCH] Fix virt-install disks typo

Mark McLoughlin markmc at redhat.com
Fri Feb 15 10:26:38 UTC 2008


# HG changeset patch
# User Mark McLoughlin <markmc at redhat.com>
# Date 1203068244 0
# Node ID fd6a7fa855d11ca890f3c60f669c1830b9874f25
# Parent  07091304b75962460fd01c419a358e1a30fecb65
Fix virt-install disks typo

Fixes this traceback:

    Traceback (most recent call last):
      File "./virt-install", line 498, in <module>
        main()
      File "./virt-install", line 462, in main
        dom = guest.start_install(conscb,progresscb)
      File "/home/markmc/projects/virt/virtinst--devel/virtinst/Guest.py", line 813, in start_install
        return self._do_install(consolecb, meter)
      File "/home/markmc/projects/virt/virtinst--devel/virtinst/Guest.py", line 829, in _do_install
        self._create_devices(meter)
      File "/home/markmc/projects/virt/virtinst--devel/virtinst/Guest.py", line 725, in _create_devices
        disk.setup(progresscb)
    AttributeError: 'str' object has no attribute 'setup'

Looks to have been introduced by cset 351:07091304b759

Signed-off-by: Mark McLoughlin <markmc at redhat.com>

diff -r 07091304b759 -r fd6a7fa855d1 virt-install
--- a/virt-install	Thu Feb 14 12:47:16 2008 -0500
+++ b/virt-install	Fri Feb 15 09:37:24 2008 +0000
@@ -91,7 +91,7 @@ def get_disk(disk, size, sparse, guest, 
                 disk = None
                 continue
 
-        guest.disks.append(disk)
+        guest.disks.append(d)
         break
 
 def get_disks(disk, size, sparse, nodisks, guest, hvm, conn):




More information about the et-mgmt-tools mailing list