[et-mgmt-tools] [PATCH] Fix virt-install disks typo

Cole Robinson crobinso at redhat.com
Fri Feb 15 15:33:12 UTC 2008


Mark McLoughlin wrote:
> # HG changeset patch
> # User Mark McLoughlin <markmc at redhat.com>
> # Date 1203068244 0
> # Node ID fd6a7fa855d11ca890f3c60f669c1830b9874f25
> # Parent  07091304b75962460fd01c419a358e1a30fecb65
> Fix virt-install disks typo
> 
> Fixes this traceback:
> 
>     Traceback (most recent call last):
>       File "./virt-install", line 498, in <module>
>         main()
>       File "./virt-install", line 462, in main
>         dom = guest.start_install(conscb,progresscb)
>       File "/home/markmc/projects/virt/virtinst--devel/virtinst/Guest.py", line 813, in start_install
>         return self._do_install(consolecb, meter)
>       File "/home/markmc/projects/virt/virtinst--devel/virtinst/Guest.py", line 829, in _do_install
>         self._create_devices(meter)
>       File "/home/markmc/projects/virt/virtinst--devel/virtinst/Guest.py", line 725, in _create_devices
>         disk.setup(progresscb)
>     AttributeError: 'str' object has no attribute 'setup'
> 
> Looks to have been introduced by cset 351:07091304b759

Argh, yes it was. Spent all my time testing the virt-clone pieces and
forgot to test virt-install :\

Applied now:
http://hg.et.redhat.com/virt/applications/virtinst--devel?cs=fd6a7fa855d1

Thanks,
Cole




More information about the et-mgmt-tools mailing list