[et-mgmt-tools] [PATCH] The bridge of bonding and the tag VLANisnot displayed in virt-manager

[S.Sakamoto]

> After much testing on some horrible different networking configs, here is
> an updated patch which I think should work correctly.
> 
>   - Instead of using /etc/modprobe.conf, it reads /sys/class/net/bonding_masters
>     to get an accurate list of bonding devices
>   - It doesn't use the HAL linux.sysfs_path patch when looking for VLANs
>     because that is /sys/devices/pci0000:00/0000:00:1e.0/0000:01:00.0/net/eth0
>     but the VLANs are only visible under /sys/class/net/eth0.*
>   - It filters out any physical devices that are part of a bonding master
>     so they don't appear in the list twice
> 
> I've tested with:
> 
>   - eth0 as bridge, and peth0 as physical device
>   - br0 as bridge and eth0 as physical device
>   - bond0 with eth0 as slave, and brbond0 as bridge
>   - eth0.5 vlan with breth05 as bridge
> 
> Which I think covers the use cases your patch was trying to address.
> 
> The algorithm it uses is thus:
> 
>   - Find all bonding master devices
>       - Add them to netdev list
>       - Mark shared if in a bridge
> 
>   - Find all physical devices from HAL
>       - Skip if a slave in a bonding device
>       - Check if renamed from ethN -> pethN
>       - Add them to netdev list
>       - Mark shared if in a bridge
> 
>       - For all VLANs associated with physical device
>            - Add them to netdev list
>            - Mark shared if in a bridge
> 
> Let me know if this patch shows the correct lists for you - if not the
> /root/.virt-manager/virt-manager.log file should contain useful debug
> output

Thank you for improving a patch.
I tested your patch.
I think that do not have any problem basically.

But, there are two points that should have revised.
  - A tag on bond is not considered.
  - cannot acquire correct bond name from bonding_master.

I made the patch that revised for the above points.
In this revision, the problem for me is solved.

Thanks,
Shigeki Sakamoto.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: connection.patch
Type: application/octet-stream
Size: 9865 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/et-mgmt-tools/attachments/20080218/7cc4bf10/attachment.obj>