[et-mgmt-tools] [PATCH] The bridge of bonding and the tag VLANisnot displayed in virt-manager

[Daniel P. Berrange]

On Mon, Feb 18, 2008 at 05:27:22PM +0900, S.Sakamoto wrote:
> > The algorithm it uses is thus:
> > 
> >   - Find all bonding master devices
> >       - Add them to netdev list
> >       - Mark shared if in a bridge
> > 
> >   - Find all physical devices from HAL
> >       - Skip if a slave in a bonding device
> >       - Check if renamed from ethN -> pethN
> >       - Add them to netdev list
> >       - Mark shared if in a bridge
> > 
> >       - For all VLANs associated with physical device
> >            - Add them to netdev list
> >            - Mark shared if in a bridge
> > 
> > Let me know if this patch shows the correct lists for you - if not the
> > /root/.virt-manager/virt-manager.log file should contain useful debug
> > output
> 
> Thank you for improving a patch.
> I tested your patch.
> I think that do not have any problem basically.
> 
> But, there are two points that should have revised.
>   - A tag on bond is not considered.
>   - cannot acquire correct bond name from bonding_master.
> 
> I made the patch that revised for the above points.
> In this revision, the problem for me is solved.

Excellant - this works for me too, so I've committed to the repo

http://hg.et.redhat.com/virt/applications/virt-manager--devel?cs=6a155cfe437c

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|