[et-mgmt-tools] [PATCH] virt-manager: show serial/parallel devices

Cole Robinson crobinso at redhat.com
Mon Jul 28 15:51:49 UTC 2008


The attached patch teaches virt-manager how to parse VM
character devices, showing them in the details section.
This patch also implements removing these devices.

There are a couple quirks though:

1) All the possible character device xml properties
   aren't accounted for. This only parses target port,
   device type, and source path. I figure this covers
   the common cases, and is easily expandable.

2) Explicit entries are only set for serial and parallel
   devices, not console devices. Since by default, console
   is really just a duplicate of the first serial device,
   we try to detect this and label said serial device as
   appropriately (seen in the second screen shot).
   This simplifies things a good deal, and makes deleting
   easier, since in order to remove the console or 
   first serial device, both xml blocks need to be removed
   simultaneously (not sure if this is a libvirt bug or not).

I've posted a couple screenshots to give a better idea:

Parallel device:
http://crobinso.fedorapeople.org/virt-manager/vmm-parallel.png

Serial device that is also the console device:
http://crobinso.fedorapeople.org/virt-manager/vmm-serial.png

Thanks,
Cole
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: virt-manager-parse-char-devs-patch
URL: <http://listman.redhat.com/archives/et-mgmt-tools/attachments/20080728/360ab162/attachment.ksh>


More information about the et-mgmt-tools mailing list