[et-mgmt-tools] [PATCH] virt-manager: show sound devices

[Cole Robinson]

Cole Robinson wrote:
> Daniel P. Berrange wrote:
>> On Mon, Jul 28, 2008 at 11:51:28AM -0400, Cole Robinson wrote:
>>> The attached patch teaches virt-manager how to parse
>>> sound device xml for virtual machines. Each separate
>>> <sound model='blah'/> will show up as a separate
>>> device in the VM details listing. The patch also
>>> implements deleting these devices.
>> ACK this is good.
>>
>>> I put a screenshot up that should explain most of the
>>> changes:
>>>
>>> http://crobinso.fedorapeople.org/virt-manager/vmm-sound.png
>> We sooooo badly need to find us a graphic designer who can build
>> a complete set of proper icons for  CPU, memory, disk, NIC, sound,
>> input, PCI and USB devices. The icons we use currently just look
>> rubbish - i'm inclined to say we should get rid of them unless
>> we can get good graphics because they're not really adding value
>> anymore.
>>
> 
> The new UI designs (which have stalled a bit) came bundled with the
> promise of new icons, so this is at least on the radar.
> 
> <snip>
> 
>>> @@ -1441,6 +1493,9 @@
>>>              elif row[HW_LIST_COL_TYPE] == HW_LIST_TYPE_INPUT and not currentInputs.has_key(row[HW_LIST_COL_DEVICE][3]):
>>>                  removeIt = True
>>>              elif row[HW_LIST_COL_TYPE] == HW_LIST_TYPE_GRAPHICS and not currentGraphics.has_key(row[HW_LIST_COL_DEVICE][3]):
>>> +                removeIt = True
>>> +            elif row[HW_LIST_COL_TYPE] == HW_LIST_TYPE_SOUND and not \
>>> +                 currentSounds.has_key(row[HW_LIST_COL_DEVICE][3]):
>> If we're going to break long lines, break all of them in that
>> conditional :-)
>>
> 

I've committed this:

http://hg.et.redhat.com/virt/applications/virt-manager--devel?cs=99c9beca2a3c

Thanks,
Cole