[et-mgmt-tools] [PATCH] virt-manager: show serial consoles as tabs in 'details' window

[Daniel P. Berrange]

On Tue, Sep 30, 2008 at 12:04:13PM -0400, Cole Robinson wrote:
> The attached patch combines the serial console window
> with the VM details window. Opening the serial console
> now appends a tab to the details view. In addition,
> multiple serial consoles are now supported, not just
> the primary/first defined console, though this still
> only works for 'pty' devices.
> 
> The patch does three things: 
> 
> 1) Remove all the previous plumbing needed to keep track
>    of the separate console window
> 2) Fix the vmmSerialConsole class to extend gtk.HBox, so
>    we can reuse most of the code in a notebook tab.
> 3) Add all the plumbing in details.py to deal with adding
>    and removing tabs on the fly.
> 
> Screenshot of a couple tab examples:
> 
> http://fedorapeople.org/~crobinso/virt-manager/vmm-serial-tab1.png
> 
> Screenshot of selecting which serial console to open
> (unsupported console types will have entries, they will
>  just be disabled as shown):
> 
> http://fedorapeople.org/~crobinso/virt-manager/vmm-serial-tab2.png
> 
> Screenshot of terminal right click menu. Tabs can be
> closed via this menu, or the 'View' menu shown in the
> second screenshot.
> 
> http://fedorapeople.org/~crobinso/virt-manager/vmm-serial-tab3.png
> 
> Any comments appreciated.

This all basically looks good to me. Though what is the behaviour
when running against a remote VM ? Do we simply not create the
extra tabs, or do we create them and populate them with a message
saying the serial console is not accessible ?  I'd probably 
suggest the latter, also doing it for non-PTY devices. This gives
the user reassurance that we have actually detected their serial
devices, and are simply unable to access them.

Eventually we can add support for connecting to at least TCP and
UNIX domain sockets fairly easily. UDP probably doesn't make any
sense in the context of virt-maanger, because that config is 
primarily for purpose of net-console logging.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|