[et-mgmt-tools] Re: [PATCH][RFC](take2)Add "Migrate" to VirtualMachine-menu in theindividual VM view

[S.Sakamoto]

> S.Sakamoto wrote:
> > Hi, Cole
> > 
> > I cleared all the problems about your comment.
> > I show the following the summary of this patch
> > and a problem about doing "Migrate" from individual VM view.
> >
> 
> Okay, this looks good, I've committed this:
> 
> http://hg.et.redhat.com/virt/applications/virt-manager--devel?cs=f47cf079e311
> 
> Though I had a few more small issues with the code. I
> worked up a patch (attached) that fixes them.
> 
> There was a bug when trying to migrate from the manager
> view: the migrate connection list won't update correctly
> if clicking around between different VM's on different
> connections. The fix was just to populate the migrate
> menu on demand, rather than when a new VM was selected.
> 
> The other change was to actually list unusable connections
> in the migrate list, but have them as inactive list entries:
> 
> http://fedorapeople.org/~crobinso/virt-manager/virt-manager-migrate.png
> 
> The disabled list entries also have tooltips which explain
> why they are disabled. I think this will be more clear to
> users if there are invalid connections.
> 
> Do you think this is an okay change?
Yes, okay!

Thanks,
Shigeki Sakamoto.