[patch] Patch to fix double call to "mock clean" in case, if mock will failed on "prep" stage.

Alexandr Kanevskiy kad at crystalowl.net
Sun Oct 30 19:26:21 UTC 2005


Hi all.

I found one small issue, that in case of mock will fail on prep stage
(no space on device, or repository access failed) mock will return
earlier, and in _status_prepping(), _watch_mock function will call
_start_cleanup(). After that _start_cleanup will change next state to be
"cleanup". But, this "if" below, will change next status to "building"
regardless of previous error:
            if not self._mock_using_repo():
                self._status = 'building'

that meas scenario: 
	_status_prepping
		_watch_mock
      			mock clean
	_status_building
		_watch_mock
			mock clean

Attached patch solves that.
-- 
Alexandr Kanevskiy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: plague-doubleclean.patch
Type: text/x-patch
Size: 583 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/fedora-buildsys-list/attachments/20051030/3904df94/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-buildsys-list/attachments/20051030/3904df94/attachment.sig>


More information about the Fedora-buildsys-list mailing list