[patch] Patch to fix double call to "mock clean" in case, if mock will failed on "prep" stage.
Dan Williams
dcbw at redhat.com
Mon Oct 31 17:02:07 UTC 2005
On Sun, 2005-10-30 at 21:26 +0200, Alexandr Kanevskiy wrote:
> Hi all.
>
> I found one small issue, that in case of mock will fail on prep stage
> (no space on device, or repository access failed) mock will return
> earlier, and in _status_prepping(), _watch_mock function will call
> _start_cleanup(). After that _start_cleanup will change next state to be
> "cleanup". But, this "if" below, will change next status to "building"
> regardless of previous error:
> if not self._mock_using_repo():
> self._status = 'building'
>
> that meas scenario:
> _status_prepping
> _watch_mock
> mock clean
> _status_building
> _watch_mock
> mock clean
>
> Attached patch solves that.
Good catch. Thanks! It's been committed to HEAD and STABLE_4.
Dan
More information about the Fedora-buildsys-list
mailing list