review request for libpst
Michael Schwendt
mschwendt at gmail.com
Thu Apr 9 08:34:28 UTC 2009
Just a look at the spec:
On Wed, 08 Apr 2009 20:30:25 -0700, Carl wrote:
> <http://www.five-ten-sg.com/libpst/packages/libpst.spec> and
> <http://www.five-ten-sg.com/libpst/packages/libpst-0.6.35-1.src.rpm>.
Requires: %{name}-libs = %{version}-%{release}
In the main utilities package, is this explicit dependency on the
library package really needed?
https://fedoraproject.org/wiki/Packaging/Guidelines#Requires
> %description devel
> libpst-devel contains the library links and header fles you'll
s/fles/files/
> %files libs
> %{_libdir}/libpst.so.*
%defattr is missing here.
> %files devel
> %{_libdir}/libpst.so
%defattr is missing here.
> %files
[...]
> %docdir %{_datadir}/doc/%{name}-%{version}
> %{_datadir}/doc/%{name}-%{version}
%_datadir/doc is in default list of documentation directories.
The %docdir line is redundant.
> %dir %{_includedir}/%{name}-2
> %{_includedir}/%{name}-2/*
Doesn't add any value
and is the same as only
%{_includedir}/%{name}-2/
More information about the fedora-devel-list
mailing list