v4l applications

[Dominik 'Rathann' Mierzejewski]

On Sunday, 06 December 2009 at 10:36, Paulo Cavalcanti wrote:
> On Sat, Dec 5, 2009 at 6:45 PM, Dominik 'Rathann' Mierzejewski <
> dominik at greysector.net> wrote:
> 
> > On Saturday, 05 December 2009 at 15:48, Paulo Cavalcanti wrote:
> > > There are some old v4l applications that do not work in Fedora 12.
> > >
> > > I found so far fmtools and gnomeradio.
> > >
> > > Gnomeradio accepts v4l2, but one has to use a gconf editor
> > > to change the driver (there is no option in the application interface).
> > >
> > > I tried to patch gnomerario, but I do not know how to force
> > > updating gconf database. I think that a new account should
> > > have the new defaults, but how do I force a change in a previously
> > created
> > > account?
> >
> > I'm the maintainer of gnomeradio, but I haven't used it for a while because
> > I'm away from my desktop PC, which has an analog tv/radio tuner card.
> > Would you be interested in co-maintaining gnomeradio?
> >
> >
> Sure. There are very few radio applications around, and they are kind of
> unmaintained upstream. I made a review request yesterday with a patched
> gqradio for working with v4l2.
> 
> gnomeradio just needs best defaults for v4l2 and a script for having sound
> using sox, because it never recognized the mixer channels of my card:
> 
> http://orion.lcg.ufrj.br/RPMS/src/gnomeradio-1.8-4.fc12.src.rpm
> 
> kradio4 works fine with v4l2 and fmtools is bkoken.

It would've been easier for me if you had just posted a patch for the specfile
along with the patch you wanted to apply to the source.

Anyway, I had a look at it and I don't like it. You're hardcoding the driver
to v4l2. I think it'd be better to simply make the autodetection try v4l2
first. Also, is it necessary to change "/dev/radio" to "/dev/radio0"?

Please try the attached patch and see if it works for you.

Thanks and regards,
R.

-- 
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu
"Faith manages."
        -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
-------------- next part --------------
diff -up gnomeradio-1.8/src/prefs.c.v4l2 gnomeradio-1.8/src/prefs.c
--- gnomeradio-1.8/src/prefs.c.v4l2	2008-04-13 15:04:52.000000000 +0200
+++ gnomeradio-1.8/src/prefs.c	2009-12-06 12:43:45.000000000 +0100
@@ -112,7 +112,7 @@ gboolean load_settings(void)
 	/* Load general settings */
 	settings.device = gconf_client_get_string(client, "/apps/gnomeradio/device" , NULL);
 	if (!settings.device)
-		settings.device = g_strdup("/dev/radio");
+		settings.device = g_strdup("/dev/radio0");
 	settings.driver = gconf_client_get_string(client, "/apps/gnomeradio/driver" , NULL);
 	if (!settings.driver)
 		settings.driver = g_strdup("any");
diff -up gnomeradio-1.8/src/radio.c.v4l2 gnomeradio-1.8/src/radio.c
--- gnomeradio-1.8/src/radio.c.v4l2	2008-04-13 14:55:43.000000000 +0200
+++ gnomeradio-1.8/src/radio.c	2009-12-06 12:44:01.000000000 +0100
@@ -41,9 +41,9 @@ int radio_init(char *device, DriverType 
 	}
 
 	switch (driver) {
+		case DRIVER_ANY:
 		case DRIVER_V4L2:
 			goto try_v4l2;
-		case DRIVER_ANY:
 		case DRIVER_V4L1:
 		default:
 			goto try_v4l1;