[Fedora-directory-devel] Please Review: (184141) pwpolicy response control not sent with passwd modify extop response

[Nathan Kinder]

https://bugzilla.redhat.com/show_bug.cgi?id=184141
esolves: bug 184141
Bug Description: If the password policy request control is present when
  performing a password modify extended operation, the associated response
  control is not sent back when there is a policy error or warning.
Reviewed by: ???
Files: see diff
Branch: HEAD
Fix Description: There are numerous issues causing the password policy 
response
  control to not be returned when using the password modify extended 
operation.

  As Rich pointed out, we were not passing the controls through to the 
internal
  modify operation.  I found that we were not setting the request 
controls in the
  pblock for any extended operations, which made it impossible to copy 
those and
  pass them into the internal modify.

  In the internal modify code, we were not setting SLAPI_PWPOLICY if the 
password
  policy control was present.  This needs to be set for the password 
policy code
  to determine if the response control needs to be sent.

  There are also a few password policy checks that are not processed for 
internal
  operations.  We need to perform these checks in the password modify 
extended
  operation code since they need to know which user is performing the 
operation,
  which is unknown when dealing with an internal operation.
Platforms tested: F9
Flag Day: no
Doc impact: no
https://bugzilla.redhat.com/attachment.cgi?id=329114&action=diff