[Fedora-electronic-lab] Re: [Fedora Electronic Lab] #23: Package qtdmm

[Fedora Electronic Lab]

#23: Package qtdmm
----------------------------+-----------------------------------------------
  Reporter:  zap            |       Owner:  chitlesh 
      Type:  task           |      Status:  new      
  Priority:  minor          |   Milestone:  Fedora 12
 Component:  analog design  |     Version:  devel    
Resolution:                 |    Keywords:           
----------------------------+-----------------------------------------------
Comment (by sherry151):

 No problem here. You can maintain this package.

 There are some problems I found with the spec file

 #1 rpmlint qtdmm-0.8.12-1.fc9.zap.src.rpm

 qtdmm.src:11: W: hardcoded-packager-tag Radek
 qtdmm.src:27: W: setup-not-quiet
 qtdmm.src:46: E: files-attr-not-set
 qtdmm.src: W: summary-ended-with-dot Digital multimeter readout software.
 qtdmm.src: W: no-version-in-last-changelog
 qtdmm.src: W: invalid-license GPL

 Doing a rpmlint on src rpm gives 5 warnings and 1 error

 To resolve the warnings do the following:

 1) Remove the 'Packager' tag
 2) Package summary should not end with a full stop.
 3) Changelog should have a release version (Note 0.8.12-1)

         * Sat Jun  6 2009 Andrew Zabolotny <zap at homelink.ru>
     54  - updated to latest version - 0.8.12-1
     55  - Fedora packaging guidelines

 Also since this is the first Fedora package, I think you can remove the
 other changelogs and add 'First Fedora Package' to the latest changelog.

 4) The license should be 'GPLv2+' This is mentioned in the website.

 To resolve the error:

 1) Change the section

 %files
 46      %doc README AUTHORS CHANGELOG COPYING
 47      %defattr(-,root,root)
 48      %{_bindir}/qtdmm

 to

 %files
 46      %defattr(-,root,root)
 47      %doc README AUTHORS CHANGELOG COPYING
 48      %{_bindir}/qtdmm

 #2 The install process does not preserve time stamps. Add '-p' after every
 install command. For exaple:
    35   install -p -d $RPM_BUILD_ROOT%{_bindir}

 #3 Install the man file. To do this you can add these lines in %install
 section

 install -p -d  $RPM_BUILD_ROOT%{_mandir}/man1
 install -p -m 644 qtdmm.1 $RPM_BUILD_ROOT%{_mandir}/man1/%{name}.1

 and add the following line to the %files section

 %{_mandir}/man1/%{name}.1.gz

 #4 I believe you should remove the 'Vendor' tag

 #5 Version of qt-devel need not be mentioned. qt3-devel should be qt-
 devel. The package builds quite perfectly with qt4-devel as well.

 #6 'Requires qt' is not required as qt-devel will always pull qt. If a
 system has qt-devel in it it will always have qt in it.

 #7 Generally 'Name' should come first followed by 'Version'. Also, the
 summary should be clear like 'A digital multimeter readout software'.

 Well that's almost all of it. Others please correct me if I have gone
 wrong somewhere.

-- 
Ticket URL: <https://fedorahosted.org/fedora-electronic-lab/ticket/23#comment:5>
Fedora Electronic Lab <https://fedorahosted.org/fedora-electronic-lab>
Design, Simulate and Program electronics.