rpms/xmms-arts/devel arts_output-0.6.0-buffer.patch, NONE, 1.1 xmms-arts.spec, NONE, 1.1 .cvsignore, 1.1, 1.2 sources, 1.1, 1.2

[Matthias Saou]

Michael Schwendt wrote :

> > %files
> > %defattr(-, root, root, 0755)
> > %doc AUTHORS ChangeLog COPYING NEWS README 
> > %{_bindir}/xmms-arts-helper
> > %{_libdir}/xmms/Output/
> 
> As that makes xmms-arts own the Output plugin directory, I'd like to
> propose this change:
> 
> +++ xmms-arts.spec      2005-04-23 09:45:05.000000000 +0200
> @@ -1,3 +1,5 @@
> +%define xmms_outputdir %(xmms-config --output-plugin-dir)
> +
>  Summary: X MultiMedia System output plugin for the aRts sound system
>  Name: xmms-arts
>  Version: 0.7.1
> @@ -40,7 +42,7 @@
>  %defattr(-, root, root, 0755)
>  %doc AUTHORS ChangeLog COPYING NEWS README 
>  %{_bindir}/xmms-arts-helper
> -%{_libdir}/xmms/Output/
> +%{xmms_outputdir}/*

This is actually done on purpose. Something I've kept doing from the days
when rpm complained about directories not being empty when removing
packages, something probably caused by the erasing ordering. If you had
all plugin packages own the main plugin directory, when rpm was asked to
remove all plugin packages as well as the main one, when starting with the
main, it wouldn't complain about the directories if they were also owned
by the plugins, and remove them properly instead of leaving them empty too.

As rpm has been silent about this problem (trying to rmdir non-empty
directories) for years, and as erasure package ordering seems to have been
fixed, this is probably not that relevant anymore.

Anyway, if we all agree, I'll change it from now on.

Matthias

-- 
Clean custom Red Hat Linux rpm packages : http://freshrpms.net/
Fedora Core release 3 (Heidelberg) - Linux kernel 2.6.11-1.14_FC3
Load : 0.20 0.21 0.17