rpms/xmms-arts/devel arts_output-0.6.0-buffer.patch, NONE, 1.1 xmms-arts.spec, NONE, 1.1 .cvsignore, 1.1, 1.2 sources, 1.1, 1.2

[Michael Schwendt]

On Mon, 25 Apr 2005 10:37:05 +0200, Matthias Saou wrote:

> Michael Schwendt wrote :
> 
> > > %files
> > > %defattr(-, root, root, 0755)
> > > %doc AUTHORS ChangeLog COPYING NEWS README 
> > > %{_bindir}/xmms-arts-helper
> > > %{_libdir}/xmms/Output/
> > 
> > As that makes xmms-arts own the Output plugin directory, I'd like to
> > propose this change:
> > 
> > +++ xmms-arts.spec      2005-04-23 09:45:05.000000000 +0200
> > @@ -1,3 +1,5 @@
> > +%define xmms_outputdir %(xmms-config --output-plugin-dir)
> > +
> >  Summary: X MultiMedia System output plugin for the aRts sound system
> >  Name: xmms-arts
> >  Version: 0.7.1
> > @@ -40,7 +42,7 @@
> >  %defattr(-, root, root, 0755)
> >  %doc AUTHORS ChangeLog COPYING NEWS README 
> >  %{_bindir}/xmms-arts-helper
> > -%{_libdir}/xmms/Output/
> > +%{xmms_outputdir}/*
> 
> This is actually done on purpose. Something I've kept doing from the days
> when rpm complained about directories not being empty when removing
> packages, something probably caused by the erasing ordering. If you had
> all plugin packages own the main plugin directory, when rpm was asked to
> remove all plugin packages as well as the main one, when starting with the
> main, it wouldn't complain about the directories if they were also owned
> by the plugins, and remove them properly instead of leaving them empty too.
> 
> As rpm has been silent about this problem (trying to rmdir non-empty
> directories) for years, and as erasure package ordering seems to have been
> fixed, this is probably not that relevant anymore.
> 
> Anyway, if we all agree, I'll change it from now on.

Please do.

According to above theory, you would treat other types of packages
equally, e.g. perl-* packages and their vendor/site install trees, and
include many more path components just to make RPM shut up.

We care less about directories, which are left over after package removal
due to how RPM works, than we care about unowned directories or incorrect
ownership of directories. Semantically, %_libdir/xmms/, the directories in
it, their access permissions and ownership, belong into the base "xmms"
package only. It would be correct to "Requires: %{_libdir}/xmms/Output"
for a package, which depends on just the directory to be present, and
get package resolvers to pull in the base xmms package.