[Bug 165314] Review Request: kismet -- A WLAN detector, sniffer and IDS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kismet -- A WLAN detector, sniffer and IDS


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165314


matthias at rpmforge.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matthias at rpmforge.net




------- Additional Comments From matthias at rpmforge.net  2005-08-18 05:55 EST -------
Just a few remarks :
- 2005-08-R1 is out and fixes important security issues.
- I find it really harder to read spec files where %variables aren't in
%{curly_braces} (breaks some displaying in vim). It also adds some possible
doubts about where the variable name stops.
- Why add the subst() function when perl or inplace sed edit works fine?
- I don't really like relying on the external "fedora-usermgmt" from the
fedora.us era for use creation/deletion. Also, where does the 12 come from and
does it guarantee there will be no clash?
- The name "IP sentinel user" for the user seems like a copy/paste mistake,
unless you're trying to share a user between multiple packages/daemons (which
IMHO should be avoided).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.