[Bug 165314] Review Request: kismet -- A WLAN detector, sniffer and IDS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kismet -- A WLAN detector, sniffer and IDS


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165314





------- Additional Comments From enrico.scholz at informatik.tu-chemnitz.de  2005-08-18 07:59 EST -------
http://ensc.de/fedora/kismet.spec
http://ensc.de/fedora/kismet-0.0.2005.08.R1-1.src.rpm

=================

> - 2005-08-R1 is out and fixes important security issues.

thx; updated


> - I find it really harder to read spec files where %variables aren't
>   in %{curly_braces}

mmh... I find it really harder to read spec files where %variables are
in %{curly_braces} ;)


>   (breaks some displaying in vim).

I tested it and it seems that there is no difference between %var and
%{var} in vim.


>   It also adds some possible doubts about where the variable name
>   stops.

I took care about this and added braces where needed.


> - Why add the subst() function when perl or inplace sed edit works fine?

ok; removed it. It happens in %prep where the files *will* be modified
so that I do not need to keep the timestamp.


> - I don't really like relying on the external "fedora-usermgmt" from
>   the fedora.us era for use creation/deletion.

I do not see an alternative as I need consistent uids across different
systems.


>   Also, where does the 12 come from and does it guarantee there will
>   be no clash?

Ok; copied http://www.fedora.us/wiki/PackageUserRegistry to
http://fedoraproject.org/wiki/PackageUserRegistry and updated it.


> - The name "IP sentinel user" for the user seems like a copy/paste
>   mistake, unless you're trying to share a user between multiple
>   packages/daemons (which IMHO should be avoided).

oops; should be fixed now


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.