[Bug 166252] Review Request: perl-Gnome2-Canvas

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Gnome2-Canvas


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166252





------- Additional Comments From jspaleta at gmail.com  2005-08-20 18:09 EST -------
(In reply to comment #10)
> So where are we?
> 
> Do I need to change anything here?


Summary of comment #5-#8

2 blockers:
1) there is build error happening "Unrecognized argument in LIBS ignored:
'-pthread'"  the Canvas.so might not be linking as the upstream authors expected
and this may or may not have an impact on functionality. You might want to ask
the upstream developer about that build time error message.

I have tested the demo program that comes with the page and it appears to work,
but I'm not if this is enough assurance.  I was hoping Ralf would comment on my
demo testing and see if that satified him since he originally found the build
error.  

Though if you can make this build error go away via specfile manipulation that
would be satifactory solution. We either need to fix the build error, get an
explanation as to why this okay to allow, or we feel confident that this problem
isn't going to affect functionality. 

2) 
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"

to make --target  work.  For future reference this(or equivalent) is part of the
perl template spec file in fedora-rpmdevtools package.


-jef

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.