rpms/tinyerp/FC-3 tinyerp.spec,1.7,1.8

[Ralf Corsepius]

On Wed, 2005-12-14 at 09:24 -0500, Dan Horak wrote:

> Index: tinyerp.spec
> ===================================================================
> RCS file: /cvs/extras/rpms/tinyerp/FC-3/tinyerp.spec,v
> retrieving revision 1.7
> retrieving revision 1.8
> diff -u -r1.7 -r1.8
> --- tinyerp.spec	11 Dec 2005 12:18:39 -0000	1.7
> +++ tinyerp.spec	14 Dec 2005 14:24:27 -0000	1.8

> @@ -106,7 +107,7 @@
>  
>  %pre server
>  /usr/sbin/fedora-groupadd 13 -r tinyerp &>/dev/null || :
> -/usr/sbin/fedora-useradd 13 -r -s /sbin/nologin -d /var/spool/tinyerp -M \
> +/usr/sbin/fedora-useradd 13 -r -s /bin/bash -d /var/spool/tinyerp -M \
>  	-c 'TinyERP Server Owner' -g tinyerp tinyerp &>/dev/null || :
Urgh

1. Why /bin/bash?
/bin/bash should _never_ be used for reserved accounts - It's a security
risk.


2. You this %pre  rule will have no effect if the user already exists.
=> This won't work.

3. Why fedora-useradd?

* Use literal account name instead of numerical ones and  a plain
user-add probably will be sufficient.
* IMO, fedora-usermgt is a design wart that should not be used anywhere.

Ralf