New Package: gDesklets0.35.1
Andreas Thienemann
andreas at bawue.net
Thu Jul 7 18:47:43 UTC 2005
On Thu, 7 Jul 2005, Kyle Pointer wrote:
> Hello. I made RPMs today for gDesklets.
> ( no widgets included [ it does point to the right resource though ])
> [yes SRPMS and SPEC files are available as well]
> Anyways those are at:
> ftp://fluffnet.serveftp.com/rpms/gDesklets/
Okay, this needs some work.
First of all:
rpmlint shows the most obvious problems:
W: gdesklets summary-ended-with-dot The gDesklets widget manager.
Please remove the dot at the end of the line.
W: gdesklets spelling-error-in-description usefull useful
Typo.
E: gdesklets description-line-too-long gDeskets are little scripts ( with
pretty pictures ) that will run on your desktop. Usefull as eye candy, to
keep track of system resources, etc.
Please add linebreaks between at 78chars or shorter.
And a better description would be appreciated
W: gdesklets no-url-tag
Please add a URL with the project homepage
E: gdesklets invalid-spec-name gDesklets-0.35.1.spec
The spec should be named gdesklets.spec
Then on to the spec file:
%setup -q -c Can be substituted by %setup -q -n gDesklets-%{version}
This will save you from having to chdir to the directory in each stage.
The %clean stage doesn't actually clean the buildroot. Fix that please.
Remove the %post message. RPM is for unattended installs, nobody will read
it. Either put a message into the description that the actual widgets are
not installed or put a README.redhat or README.fedora into the docdir.
%files do not contain any docs nor the COPYING file. Fix that.
you are using full paths in the %files section. Please use the shorthand
macros such as %{_datadir} and %{_bindir} etc.
%changelog does not contain the version release for which the changelog
entry applies.
Please fix these errors and submit a new spec, which I will review in
depth.
bye,
andreas
More information about the fedora-extras-list
mailing list