Request for review: libgeotiff

[Shawn McCann]

Ralf,

Thanks for the feedback. I've updated the file to address all your
comments and posted the new version.

SPEC: http://www.canasoft.ca/fedora/libgeotiff.spec
SRPM: http://www.canasoft.ca/fedora/libgeotiff-1.2.2-1.src.rpm

However, I'm having one problem now. The base package includes two
executables that link to libgeotiff.so (which is why I had libgeotiff.so
in the base package and included it in the Provides: directive). Now that
I've moved libgeotiff.so back to the devel package, the base package won't
install as it can't find libgeotiff.so. Any advice on how to deal with
this?

Thanks

Shawn


> On Fri, 2005-07-15 at 21:38 -0700, Shawn McCann wrote:
>> As part of an effort to add some GIS tools to extras (namely Quantum GIS
>> and
>> GRASS), I've packaged up libgeotiff for extras:
>>
>> SPEC: http://www.canasoft.ca/fedora/libgeotiff.spec
>> SRPM: http://www.canasoft.ca/fedora/libgeotiff-1.2.2-1.src.rpm
>
> This spec is not ready for inclusion.
>
> * Blockers:
> - Installation to /usr/local (Use %configure instead of ./configure).
> - Permissions on many installed files are wrong (E.g. executable
> headers, executable static libs, executable data files).
> - Package does not acknowledge RPM_OPT_FLAGS (Use %configure instead
> of ./configure)
> - Shared libraries are packaged incorrectly (lib*.so belongs into
> *devel, lib*.so.* into non-devel).
> - The "Provides:" line is wrong.
>
> * Non-blockers:
> - Headers are installed to $(includedir), which means they pollute the
> system header namespace. I'd recommend to install the headers into a
> subdir of $(includedir) (i.e. %configure --includedir=
> %{_includedir}/geotiff or similar).
> - I recommend not to ship static libs (lib*.a)
>
> Ralf
>
>
> --
> fedora-extras-list mailing list
> fedora-extras-list at redhat.com
> https://www.redhat.com/mailman/listinfo/fedora-extras-list
>