Request for review / approval: frotz.

[Tom 'spot' Callaway]

On Tue, 2005-07-19 at 07:11 -0700, Chris Grau wrote:

> Here are the updated files:
> 
>   http://www.chrisgrau.com/packages/frotz/frotz.spec
>   http://www.chrisgrau.com/packages/frotz/frotz-2.43-2.fc4.cdg.src.rpm

Review: frotz

Good:

- rpmlint checks return nothing
- naming OK
- meets PackagingGuidelines
- License OK (GPL), matches code, text of license in %doc
- source matches upstream
- package compiles, builds, runs on FC4 (x86)
- no locales
- spec is legible, in am. english
- no excluded BR, no missing BR
- no shared/static libraries
- no -devel/-docs
- not relocatable
- owns all directories it creates
- file attribs ok
- no duplicate files
- %clean OK
- macro use is consistent
- code, not content
- nothing in %doc affects runtime

APPROVED. Very good first package. :)

Now, what you need to do is go ahead and get an account here:
https://admin.fedora.redhat.com/accounts/

When your paperwork is in, I'll sponsor you.

~spot
-- 
Tom "spot" Callaway: Red Hat Senior Sales Engineer || GPG ID: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!