Request for review: gnome-applet-bubblemon

[Ignacio Vazquez-Abrams]

On Thu, 2005-07-28 at 07:24 -0300, Nicolás Wolovick wrote:
> SPEC:http://www.cs.famaf.unc.edu.ar/~nicolasw/Otros/gnome-applet-bubblemon.spec

- Remove the hardcoded disttags
- Remove the explicit Requires
- --prefix and --mandir are redundant with %configure
- Variables should come after make in the command line, not before
- Use install, not install-strip in %install
- Should not own %{_datadir}/gnome-2.0
- Use %find_lang instead of owning %{_datadir}/locale

-- 
Ignacio Vazquez-Abrams <ivazquez at ivazquez.net>
http://fedora.ivazquez.net/

gpg --keyserver hkp://subkeys.pgp.net --recv-key 38028b72
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050728/92024421/attachment.sig>